8000 Use `rspec-memory` and `rspec-files` for non-async specific helpers. · socketry/async-rspec@0c84d80 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0c84d80

Browse files
ioquatixioquatix
committed
Use rspec-memory and rspec-files for non-async specific helpers.
1 parent 11b2d63 commit 0c84d80

File tree

6 files changed

+8
-283
lines changed

6 files changed

+8
-283
lines changed

‎.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@
1010

1111
# rspec failure tracking
1212
.rspec_status
13+
.covered.db

‎async-rspec.gemspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ Gem::Specification.new do |spec|
1717
spec.require_paths = ["lib"]
1818

1919
spec.add_dependency "rspec", "~> 3.0"
20+
spec.add_dependency "rspec-memory", "~> 1.0"
21+
spec.add_dependency "rspec-files", "~> 1.0"
2022

2123
# Since we test the shared contexts, we need some bits of async:
2224
spec.add_development_dependency "async", "~> 1.8"

‎lib/async/rspec/leaks.rb

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,31 +18,10 @@
1818
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
1919
# THE SOFTWARE.
2020

21+
require 'rspec/files'
22+
2123
module Async
2224
module RSpec
23-
module Leaks
24-
def current_ios(gc: GC.start)
25-
all_ios = ObjectSpace.each_object(::IO).to_a.sort_by(&:object_id)
26-
27-
# We are not interested in ios that have been closed already:
28-
return all_ios.reject{|io| io.closed?}
29-
end
30-
end
31-
32-
::RSpec.shared_context Leaks do
33-
include Leaks
34-
35-
let(:before_ios) {current_ios}
36-
let(:after_ios) {current_ios}
37-
38-
# We use around(:each) because it's the highest priority.
39-
around(:each) do |example|
40-
before_ios
41-
42-
example.run.tap do
43-
expect(after_ios).to be == before_ios
44-
end
45-
end
46-
end
25+
Leaks = ::RSpec::Files::Leaks
4726
end
4827
end

‎lib/async/rspec/memory.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,10 @@
1818
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
1919
# THE SOFTWARE.
2020

21-
require_relative 'memory/limit_allocations'
21+
require 'rspec/memory'
2222

2323
module Async
2424
module RSpec
25-
::RSpec.shared_context Memory do
26-
include Memory
27-
end
25+
Memory = ::RSpec::Memory
2826
end
2927
end

‎lib/async/rspec/memory/limit_allocations.rb

Lines changed: 0 additions & 115 deletions
This file was deleted.

‎lib/async/rspec/memory/trace.rb

Lines changed: 0 additions & 140 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0