8000 Updated Project Swift variable to 4.0 · socketio/socket.io-client-swift@d3aaaec · GitHub
[go: up one dir, main page]

Skip to content

Commit d3aaaec

Browse files
committed
Updated Project Swift variable to 4.0
Fixed handleOpen(openData) bug that was not covered in the unit tests.
1 parent 46d982d commit d3aaaec

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Socket.IO-Client-Swift.xcodeproj/project.pbxproj

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1102,7 +1102,7 @@
11021102
SDKROOT = macosx;
11031103
SKIP_INSTALL = YES;
11041104
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
1105-
SWIFT_VERSION = 3.0;
1105+
SWIFT_VERSION = 4.0;
11061106
VERSIONING_SYSTEM = "apple-generic";
11071107
VERSION_INFO_PREFIX = "";
11081108
};
@@ -1154,7 +1154,7 @@
11541154
PRODUCT_BUNDLE_IDENTIFIER = "io.socket.$(PRODUCT_NAME:rfc1034identifier)";
11551155
SDKROOT = macosx;
11561156
SKIP_INSTALL = YES;
1157-
SWIFT_VERSION = 3.0;
1157+
SWIFT_VERSION = 4.0;
11581158
VERSIONING_SYSTEM = "apple-generic";
11591159
VERSION_INFO_PREFIX = "";
11601160
};
@@ -1313,6 +1313,7 @@
13131313
SDKROOT = appletvos;
13141314
SKIP_INSTALL = YES;
13151315
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
1316+
SWIFT_VERSION = 4.0;
13161317
TARGETED_DEVICE_FAMILY = 3;
13171318
TVOS_DEPLOYMENT_TARGET = 9.0;
13181319
VERSIONING_SYSTEM = "apple-generic";
@@ -1364,6 +1365,7 @@
13641365
PRODUCT_NAME = SocketIO;
13651366
SDKROOT = appletvos;
13661367
SKIP_INSTALL = YES;
1368+
SWIFT_VERSION = 4.0;
13671369
TARGETED_DEVICE_FAMILY = 3;
13681370
TVOS_DEPLOYMENT_TARGET = 9.0;
13691371
VALIDATE_PRODUCT = YES;

Source/SocketEngine.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ public final class SocketEngine : NSObject, URLSessionDelegate, SocketEnginePoll
540540
case .pong:
541541
handlePong(with: fixedString)
542542
case .open:
543-
handleOpen(openData: fixedString)
543+
handleOpen(openData: String(fixedString.dropFirst()))
544544
case .close:
545545
handleClose(fixedString)
546546
default:

0 commit comments

Comments
 (0)
0