Fix getString() freeze on empty responses (espressif#4317)

wadimdz · web-flow · commit aa529eb5a0dd · 2020-10-01T15:36:23.000+03:00
diff --git a/libraries/HTTPClient/src/HTTPClient.cpp b/libraries/HTTPClient/src/HTTPClient.cpp
@@ -921,13 +921,16 @@ String HTTPClient::getString(void)
 {
     StreamString sstring;
 
-    if(_size) {
+    if(_size > 0) {
         // try to reserve needed memmory
         if(!sstring.reserve((_size + 1))) {
             log_d("not enough memory to reserve a string! need: %d", (_size + 1));
             return "";
         }
     }
+    else {
+        return "";
+    }
 
     writeToStream(&sstring);
     return sstring;

Original file line number	Diff line number	Diff line change
`@@ -921,13 +921,16 @@ String HTTPClient::getString(void)`
`921`	`921`	`{`
`922`	`922`	`StreamString sstring;`
`923`	`923`
`924`		`- if(_size) {`
	`924`	`+ if(_size > 0) {`
`925`	`925`	`// try to reserve needed memmory`
`926`	`926`	`if(!sstring.reserve((_size + 1))) {`
`927`	`927`	`log_d("not enough memory to reserve a string! need: %d", (_size + 1));`
`928`	`928`	`return "";`
`929`	`929`	`}`
`930`	`930`	`}`
	`931`	`+ else {`
	`932`	`+ return "";`
	`933`	`+ }`
`931`	`934`
`932`	`935`	`writeToStream(&sstring);`
`933`	`936`	`return sstring;`