pylint: Latest updates on skills libraries - internals, http_helper and bf_skill_client pending

axelsrz · axelsrz · commit f8b655a8ad48 · 2019-11-14T19:02:23.000-08:00
diff --git a/libraries/botbuilder-core/botbuilder/core/bot_adapter.py b/libraries/botbuilder-core/botbuilder/core/bot_adapter.py
@@ -82,7 +82,7 @@ async def process_activity_with_claims(
         self,
         identity: ClaimsIdentity,
         activity: Activity,
-        callback: Callable[[TurnContext], Awaitable],
+        logic: Callable[[TurnContext], Awaitable],
     ):  # pylint: disable=unused-argument
         raise NotImplementedError()
 
diff --git a/libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py b/libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py
@@ -128,7 +128,7 @@ def __init__(self, settings: BotFrameworkAdapterSettings):
                 GovernmentConstants.TO_CHANNEL_FROM_BOT_OAUTH_SCOPE
             )
 
-        self._APP_CREDENTIALS_CACHE: Dict[str, MicrosoftAppCredentials] = {}
+        self._app_credentials_cache: Dict[str, MicrosoftAppCredentials] = {}
 
     async def continue_conversation(
         self, bot_id: str, reference: ConversationReference, callback: Callable
@@ -701,15 +701,15 @@ async def _get_app_credentials(
             return MicrosoftAppCredentials(None, None)
 
         cache_key = f"{app_id}{oauth_scope}"
-        app_credentials = self._APP_CREDENTIALS_CACHE.get(cache_key)
+        app_credentials = self._app_credentials_cache.get(cache_key)
 
         if app_credentials:
             return app_credentials
 
         # If app credentials were provided, use them as they are the preferred choice moving forward
         if self._credentials.microsoft_app_id:
             # Cache credentials
-            self._APP_CREDENTIALS_CACHE[cache_key] = self._credentials
+            self._app_credentials_cache[cache_key] = self._credentials
             return self._credentials
 
         app_password = await self._credential_provider.get_app_password(app_id)
@@ -724,5 +724,5 @@ async def _get_app_credentials(
                 GovernmentConstants.TO_CHANNEL_FROM_BOT_OAUTH_SCOPE
             )
 
-        self._APP_CREDENTIALS_CACHE[cache_key] = app_credentials
+        self._app_credentials_cache[cache_key] = app_credentials
         return app_credentials
diff --git a/libraries/botbuilder-skills/botbuilder/skills/channel_api_middleware.py b/libraries/botbuilder-skills/botbuilder/skills/channel_api_middleware.py
@@ -13,7 +13,7 @@
 
 class ChannelApiMiddleware(Middleware):
     def __init__(self, skill_adapter: SkillClient):
-        self._SKILL_ADAPTER = skill_adapter
+        self._skill_adapter = skill_adapter
 
     async def on_turn(
         self, context: TurnContext, logic: Callable[[TurnContext], Awaitable]
