Use destructor to close session (partially reverted #348) (#412)

supersmile2009 · curry684 · commit b133296022a1 · 2018-04-18T15:15:08.000+02:00
* Use destructor to shutdown session (partially reverted #348) * Register shutdown function only if session locking is enabled (cherry picked from commit ae3a607)
diff --git a/Session/Storage/Handler/RedisSessionHandler.php b/Session/Storage/Handler/RedisSessionHandler.php
@@ -101,7 +101,9 @@ public function __construct($redis, array $options = array(), $prefix = 'session
             $this->lockMaxWait = self::DEFAULT_MAX_EXECUTION_TIME;
         }
 
-        register_shutdown_function(array($this, 'shutdown'));
+        if (true === $locking) {
+            register_shutdown_function(array($this, 'shutdown'));
+        }
     }
 
     /**
@@ -277,7 +279,16 @@ protected function getRedisKey($key)
     /**
      * Shutdown handler, replacement for class destructor as it might not be called.
      */
-    public function shutdown() {
+    public function shutdown()
+    {
         $this->close();
     }
+
+    /**
+     * Destructor.
+     */
+    public function __destruct()
+    {
+        $this->shutdown();
+    }
 }
