#400 Utilize kernel.reset to ensure connections have been closed in tests

ostrolucky · ostrolucky · commit a258c3bf6466 · 2021-10-23T19:37:14.000+02:00
diff --git a/Resources/config/session.xml b/Resources/config/session.xml
@@ -11,7 +11,8 @@
     </parameters>
 
     <services>
-        <service id="snc_redis.session.handler" class="%snc_redis.session.handler.class%" public="true">
+        <service id="snc_redis.session.handler" class="%snc_redis.session.handler.class%">
+            <tag name="kernel.reset" method="close"/>
             <argument type="service" id="snc_redis.session.client" />
             <argument>%session.storage.options%</argument>
             <argument>%snc_redis.session.prefix%</argument>
diff --git a/SncRedisBundle.php b/SncRedisBundle.php
@@ -34,17 +34,4 @@ public function build(ContainerBuilder $container)
         $container->addCompilerPass(new SwiftMailerPass());
         $container->addCompilerPass(new ClientLocatorPass());
     }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function shutdown()
-    {
-        // Close session handler connection to avoid using up all available connection slots in tests
-        if ($this->container->has('snc_redis.session.handler')) {
-            if (!method_exists($this->container, 'initialized') || $this->container->initialized('snc_redis.session.handler')) {
-                $this->container->get('snc_redis.session.handler')->close();
-            }
-        }
-    }
 }
