atom: bug fix for attachment author objects with no properties

snarfed · snarfed · commit 64df34a644a9 · 2019-02-13T14:27:47.000-08:00
https://console.cloud.google.com/errors/CMPawqSghuDquwE
diff --git a/README.md b/README.md
@@ -309,6 +309,7 @@ Changelog
   * Don't enclose bare URLs in `<`/`>` ([snarfed/bridgy#850](https://github.com/snarfed/bridgy/issues/850)).
 * Atom:
   * Bug fix for actors and attachments with multiple image URLs.
+  * Bug fix for attachment author objects with no properties.
 * Google+:
   * Drop from web UI and API since [consumer Google+ is shutting down entirely](https://blog.google/technology/safety-security/expediting-changes-google-plus/) ([more](https://github.com/snarfed/bridgy/issues/846)).
   * Switch from deprecated global API endpoint to G+ endpoint. Background in [snarfed/bridgy#846](https://github.com/snarfed/bridgy/issues/846), [Google blog post](https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html) [and docs](https://developers.google.com/api-client-library/python/guide/batch).
diff --git a/granary/atom.py b/granary/atom.py
@@ -398,7 +398,7 @@ def _prepare_activity(a, reader=True):
       author = att.get('author')
       if author:
         name = microformats2.maybe_linked_name(
-          microformats2.object_to_json(author).get('properties', []))
+          microformats2.object_to_json(author).get('properties') or {})
         html = '%s: %s' % (name.strip(), html)
       children.append(html)
 
diff --git a/granary/tests/test_atom.py b/granary/tests/test_atom.py
@@ -175,6 +175,19 @@ def test_activity_to_atom_like(self):
         'object': obj,
       }), ignore_blanks=True)
 
+  def test_activity_to_atom_author_without_properties(self):
+    """https://console.cloud.google.com/errors/CMPawqSghuDquwE"""
+    self.assertIn('<title>foo</title>', atom.activity_to_atom({
+      'object': {
+        'title': 'foo',
+        'attachments': [{
+          'objectType': 'article',
+          'author': {
+            'objectType': 'person'
+          },
+        }],
+      }}))
+
   def test_atom_to_activity_reply(self):
     expected = {
       'objectType': 'activity',
