[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try harder to delete bridged accounts when the source account is deleted #1304

Closed
breadguyyy opened this issue Sep 5, 2024 · 9 comments
Closed
Labels

Comments

@breadguyyy
Copy link

https://bsky.app/profile/breadguyyy.c.wtf.ap.brid.gy
the original account no longer exists for this one

@snarfed
Copy link
Owner
snarfed commented Sep 5, 2024

Ooh, thanks for reporting! Looks like we currently delete Bluesky bridged profiles when someone opts out, but not when they delete their fediverse account. We should! Should be straightforward.

@breadguyyy
Copy link
Author

MVP 🙏 cheers!

@snarfed
Copy link
Owner
snarfed commented Sep 5, 2024

Actually, I take it back. The immediate problem here was that when Bridgy Fed followed you back from @bsky.brid.gy@bsky.brid.gy, c.wtf choked on that Follow activity and returned 500 "error". I expect this is the same Pleroma incompatibility as #12 / https://git.pleroma.social/pleroma/pleroma/-/issues/3206.

Since c.wtf never got that follow, it never started sending Bridgy Fed your activities, including the Delete when you deleted your account, so Bridgy Fed never knew it should disable your bridged Bluesky account.

@snarfed
Copy link
Owner
snarfed commented Sep 5, 2024

Here's the Follow activity, sent at 2024-08-08 17:56:28 UTC:

POST https://c.wtf/users/breadguyyy/inbox
{
  "@context": "https://www.w3.org/ns/activitystreams",
  "type": "Follow",
  "id": "https://bsky.brid.gy/r/https://bsky.brid.gy/#follow-back-https://c.wtf/users/breadguyyy-2024-08-08T17:40:53.226091+00:00",
  "actor": "https://bsky.brid.gy/bsky.brid.gy",
  "object": "https://c.wtf/users/breadguyyy",
  "to": ["https://www.w3.org/ns/activitystreams#Public"]
}

@cuducos
Copy link
cuducos commented Sep 8, 2024

Same issue here. I added #nobridge to my website and apparently the user page does not exist anymore (as expected): https://fed.brid.gy/web/cuducos.me gives me a 404.

However, the Bluesky account still exists : /

It was a few minutes ago, but I was hoping not to leave the #nobrige live on my website for that long…

@snarfed snarfed added the now label Sep 9, 2024
snarfed added a commit that referenced this issue Sep 14, 2024
so that User.enabled_protocols is still populated during deliver

for #1304
@snarfed
Copy link
Owner
snarfed commented Sep 14, 2024

OK, added an integration test for fediverse => Bluesky. If a fediverse account accepts @bsky.brid.gy@bsky.brid.gy's follow, we correctly deleted them.

@breadguyyy and @cuducos, I've deleted your bridged Bluesky accounts. Remaining work here is to add an integration test for web too.

@snarfed snarfed changed the title deleted soapbox account (AP) still exists on bsky Try harder to delete bridged accounts when the source account is deleted Sep 15, 2024
snarfed added a commit that referenced this issue Sep 16, 2024
snarfed added a commit that referenced this issue Sep 17, 2024
@snarfed
Copy link
Owner
snarfed commented Sep 17, 2024

Done!

@snarfed snarfed closed this as completed Sep 17, 2024
@cuducos
Copy link
cuducos commented Sep 17, 2024

Awesome ✨ Thank you so much : )

@breadguyyy
Copy link
Author

MVP 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants