Double speed of DynamicJsonDocument::garbageCollect()

bblanchon · bblanchon · commit 9bb3f4051d0f · 2023-03-20T12:32:52.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 ArduinoJson: change log
 =======================
 
+HEAD
+----
+
+* Double speed of `DynamicJsonDocument::garbageCollect()`
+
 v6.21.0 (2023-03-14)
 -------
 
diff --git a/src/ArduinoJson/Document/BasicJsonDocument.hpp b/src/ArduinoJson/Document/BasicJsonDocument.hpp
@@ -127,7 +127,6 @@ class BasicJsonDocument : AllocatorOwner<TAllocator>, public JsonDocument {
     BasicJsonDocument tmp(*this);
     if (!tmp.capacity())
       return false;
-    tmp.set(*this);
     moveAssignFrom(tmp);
     return true;
   }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,6 @@ class BasicJsonDocument : AllocatorOwner<TAllocator>, public JsonDocument {`
`127`	`127`	`BasicJsonDocument tmp(*this);`
`128`	`128`	`if (!tmp.capacity())`
`129`	`129`	`return false;`
`130`		`- tmp.set(*this);`
`131`	`130`	`moveAssignFrom(tmp);`
`132`	`131`	`return true;`
`133`	`132`	`}`