Add lock to credential cache modifications

bording · bording · commit 665eb5f3d8de · 2020-11-07T12:26:53.000-05:00
diff --git a/LibGit2Sharp/Core/ManagedHttpSmartSubtransport.cs b/LibGit2Sharp/Core/ManagedHttpSmartSubtransport.cs
@@ -186,11 +186,17 @@ private HttpResponseMessage GetResponseWithRedirects()
 
                             if (cred is DefaultCredentials)
                             {
-                                credentialCache.Add(url, scheme, CredentialCache.DefaultNetworkCredentials);
+                                lock (credentialCache)
+                                {
+                                    credentialCache.Add(url, scheme, CredentialCache.DefaultNetworkCredentials);
+                                }
                             }
                             else if (cred is UsernamePasswordCredentials userpass)
                             {
-                                credentialCache.Add(url, scheme, new NetworkCredential(userpass.Username, userpass.Password));
+                                lock (credentialCache)
+                                {
+                                    credentialCache.Add(url, scheme, new NetworkCredential(userpass.Username, userpass.Password));
+                                }
                             }
 
                             continue;

Original file line number	Diff line number	Diff line change
`@@ -186,11 +186,17 @@ private HttpResponseMessage GetResponseWithRedirects()`
`186`	`186`
`187`	`187`	`if (cred is DefaultCredentials)`
`188`	`188`	`{`
`189`		`- credentialCache.Add(url, scheme, CredentialCache.DefaultNetworkCredentials);`
	`189`	`+ lock (credentialCache)`
	`190`	`+ {`
	`191`	`+ credentialCache.Add(url, scheme, CredentialCache.DefaultNetworkCredentials);`
	`192`	`+ }`
`190`	`193`	`}`
`191`	`194`	`else if (cred is UsernamePasswordCredentials userpass)`
`192`	`195`	`{`
`193`		`- credentialCache.Add(url, scheme, new NetworkCredential(userpass.Username, userpass.Password));`
	`196`	`+ lock (credentialCache)`
	`197`	`+ {`
	`198`	`+ credentialCache.Add(url, scheme, new NetworkCredential(userpass.Username, userpass.Password));`
	`199`	`+ }`
`194`	`200`	`}`
`195`	`201`
`196`	`202`	`continue;`