8000 [BUGFIX] [Hacker Rank]: Warmup: Mini-Max Sum. · sir-gon/algorithm-exercises-cpp@86275d4 · GitHub
[go: up one dir, main page]
Skip to content

Commit 86275d4

Browse files
author
Gonzalo Diaz
committed
[BUGFIX] [Hacker Rank]: Warmup: Mini-Max Sum.
[BUGFIX] [Hacker Rank]: Warmup: A Very Big Sum. Windows "long" type is not enough to store a very big result.
1 parent fc0ea94 commit 86275d4

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

‎src/lib/exercises/include/exercises/hackerrank/warmup/a_very_big_sum.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
#pragma once
44

55
namespace hackerrank::warmup {
6-
long aVeryBigSum(const std::vector<long> &ar);
6+
long long aVeryBigSum(const std::vector<long> &ar);
77
}

‎src/lib/exercises/src/hackerrank/warmup/a_very_big_sum.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
namespace hackerrank::warmup {
1111

12-
long aVeryBigSum(const std::vector<long> &ar) {
13-
const long INIT_VALUE = 0L;
12+
long long aVeryBigSum(const std::vector<long> &ar) {
13+
const long long INIT_VALUE = 0L;
1414
return std::accumulate(ar.begin(), ar.end(), INIT_VALUE);
1515
}
1616

‎src/lib/exercises/src/hackerrank/warmup/mini_max_sum.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ std::string miniMaxSumCalculate(const std::vector<int> &arr) {
1717
throw std::invalid_argument("List too short. Pass at least 2 elements.");
1818
}
1919

20-
long tsum = 0;
21-
long tmin = arr[0];
22-
long tmax = arr[1];
20+
long long tsum = 0;
21+
long long tmin = arr[0];
22+
long long tmax = arr[1];
2323

2424
for (const int &value : arr) {
25-
auto cvalue = (long)value;
25+
auto cvalue = (long long)value;
2626
tsum += cvalue;
2727
tmin = std::min(tmin, cvalue);
2828
tmax = std::max(tmax, cvalue);

‎src/tests/unit/lib/hackerrank/warmup/a_very_big_sum.test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ TEST_CASE("aVeryBigSum JSON Test Cases",
2222
json data = json::parse(f);
2323

2424
for (auto testcase : data) {
25-
long result = hackerrank::warmup::aVeryBigSum(testcase["input"]);
25+
long long result = hackerrank::warmup::aVeryBigSum(testcase["input"]);
2626
CHECK(result == testcase["expected"]);
2727
}
2828
}

0 commit comments

Comments
 (0)
0