8000 [backend:improvement] Support for async functions by kkampli-singlestore · Pull Request #70 · singlestore-labs/singlestoredb-python · GitHub
[go: up one dir, main page]
Skip to content

[backend:improvement] Support for async functions #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[backend:improvement] Support for async functions #70

wants to merge 1 commit into from

Conversation

kkampli-singlestore
Copy link

This PR adds a check to see if the UDF is async or not in the vector input UDF call.

  1. If the func is async, await to call it directly.
  2. If the func is sync, run it in a separate thread and await the result.

@kkampli-singlestore kkampli-singlestore marked this pull request as draft June 26, 2025 07:51
@kkampli-singlestore kkampli-singlestore force-pushed the users/kaushik/aysnc-support branch from f62de29 to 42313b0 Compare June 27, 2025 13:33
@kesmit13
Copy link
Collaborator

FYI, there is another branch (cancel_udf) that implement async functions already. It also allows for non-async functions to be cancelled if the connection to the database engine is broken.

@kesmit13
Copy link
Collaborator

The PR is #64 . It just needs to be tested a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkampli-singlestore @kesmit13
0