8000 Fix all Docker image build and push issues (#433) · sinanuozdemir/twilio-python@8107ef0 · GitHub
[go: up one dir, main page]
Skip to content

Commit 8107ef0

Browse files
author
Jonatas Baldin
authored
Fix all Docker image build and push issues (twilio#433)
* Put all commands in one line, add skip_cleanup flag * Add more secure Docker login, fix wrong push tag
1 parent 64e75f7 commit 8107ef0

File tree

< 8000 div class="d-flex flex-items-center flex-justify-between gap-2 pt-3 pt-lg-4 pb-2 position-sticky top-0 color-bg-default" style="z-index:2">

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

‎.travis.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@ script:
1414
- make test
1515
deploy:
1616
provider: script
17-
script:
18-
- make docker-build
19-
- make docker-push
17+
script: make docker-build && make docker-push
18+
skip_cleanup: true
2019
on:
2120
tags: true
2221
python: "3.6"

‎Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@ docker-build:
5353
docker tag twilio/twilio-python twilio/twilio-python:apidefs-${API_DEFINITIONS_SHA}
5454

5555
docker-push:
56-
docker login -u ${DOCKER_USERNAME} -p ${DOCKER_PASSWORD}
56+
echo ${DOCKER_PASSWORD} | docker login -u ${DOCKER_USERNAME} --password-stdin
5757
docker push twilio/twilio-python:${TRAVIS_TAG}
58-
docker push twilio/twilio-python:apidefs-${API_DEFINITIONS_TAG}
58+
docker push twilio/twilio-python:apidefs-${API_DEFINITIONS_SHA}

0 commit comments

Comments
 (0)
0