minor symfony#18400 Lower complexity of Form:isValid() (krzysiekpiasecki)

fabpot · fabpot · commit 83bb723dbb7d · 2016-04-01T09:09:21.000+02:00
This PR was squashed before being merged into the 2.7 branch (closes symfony#18400). Discussion ---------- Lower complexity of Form:isValid() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Replace symfony#18391 - use Yoda condition, - merge into 2.7 branch Why? - lower LOC - less return expressions - lower complexity - more readable comparison Commits ------- d583ec3 Lower complexity of Form:isValid()
diff --git a/src/Symfony/Component/Form/Form.php b/src/Symfony/Component/Form/Form.php
@@ -766,11 +766,7 @@ public function isValid()
             return true;
         }
 
-        if (count($this->getErrors(true)) > 0) {
-            return false;
-        }
-
-        return true;
+        return 0 === count($this->getErrors(true));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -766,11 +766,7 @@ public function isValid()`
`766`	`766`	`return true;`
`767`	`767`	`}`
`768`	`768`
`769`		`- if (count($this->getErrors(true)) > 0) {`
`770`		`- return false;`
`771`		`- }`
`772`		`-`
`773`		`- return true;`
	`769`	`+ return 0 === count($this->getErrors(true));`
`774`	`770`	`}`
`775`	`771`
`776`	`772`	`/**`