8000 Refactor: remove `sigstore.hashes`, merge into `sigstore.models` · Issue #1043 · sigstore/sigstore-python · GitHub
[go: up one dir, main page]
Skip to content

Refactor: remove sigstore.hashes, merge into sigstore.models #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
woodruffw opened this issue Jun 12, 2024 · 1 comment
Open

Refactor: remove sigstore.hashes, merge into sigstore.models #1043

woodruffw opened this issue Jun 12, 2024 · 1 comment
Assignees
@woodruffw
Labels
enhancement New feature or request refactoring Refactoring tasks.

Comments

@woodruffw
Copy link
Member

sigstore.hashes only contains a single API, which is a data model. It should probably be in sigstore.models instead.

This would be a breaking change, since it's an API rename. So we'd either need to do it in 4.x or include a backwards-compatible import.
@woodruffw woodruffw added enhancement New feature or request refactoring Refactoring tasks. labels Jun 12, 2024
@woodruffw woodruffw self-assigned this Jun 12, 2024
@woodruffw
Copy link
Member Author

Messed around with this a little, and it's going to be annoying due to all of the cyclical module dependencies it'll cause (due to things going from sigstore.hashes to sigstore.models). So we'll need to clean those up before doing the refactor here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
enhancement 3D59 New feature or request refactoring Refactoring tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@woodruffw
0