8000 Support actions/upload-artifact@v4 · Issue #100 · sigstore/gh-action-sigstore-python · GitHub
[go: up one dir, main page]
Skip to content

Support actions/upload-artifact@v4 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
esev opened this issue Jan 9, 2024 · 4 comments
Closed

Support actions/upload-artifact@v4 #100

esev opened this issue Jan 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@esev
Copy link
esev commented Jan 9, 2024

Description

actions/upload-artifact@v3 does not seem to be compatible with actions/download-artifact@v4. https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes

It would be helpful if there was a version of gh-action-sigstore-python that was (optionally?) compatible with actions/download-artifact@v4.
@esev esev added the enhancement New feature or request label Jan 9, 2024
@jku
Copy link
Member
jku commented Jan 9, 2024 •
edited
Loading

Agreed. When that update is released, the release notes should mention that download-artifact >= v4 is required (I wish GitHub also did the same with upload-artifact and download-artifact release notes but no, you need to click through READMEs to possibly find a mention...)

We should also add a dependabot config to make these update PRs

@woodruffw
Copy link
Member

Yeah, requiring >= 4 makes sense to me. And +1 to mentioning it in the release notes.

We should also add a dependabot config to make these update PRs

I'll do this today.

@woodruffw woodruffw mentioned this issue Jan 9, 2024
Merged
@woodruffw
Copy link
Member

#101 adds a dependabot config.

@woodruffw
Copy link
Member

#101 and #102 have been merged, meaning that @v4 is now supported on main. I've done a prerelease to confirm that it works, and we'll likely ship this with the next minor release (with a notice in the release notes about breakage with @v3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jku @esev @woodruffw
0