8000 Merge pull request #1241 from Microsoft/drop_unused_variables · siddharthverma/TypeScript@9d079b4 · GitHub
[go: up one dir, main page]
Skip to content

Commit 9d079b4

Browse files
vladimavladima
committed
Merge pull request microsoft#1241 from Microsoft/drop_unused_variables
drop unused variables
2 parents dc3bd6a + 9781c05 commit 9d079b4

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

‎src/compiler/parser.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2664,8 +2664,6 @@ module ts {
26642664

26652665
function parseReturnStatement(): ReturnStatement {
26662666
var node = <ReturnStatement>createNode(SyntaxKind.ReturnStatement);
2667-
var returnTokenStart = scanner.getTokenPos();
2668-
var returnTokenLength = scanner.getTextPos() - returnTokenStart;
26692667

26702668
parseExpected(SyntaxKind.ReturnKeyword);
26712669
if (!canParseSemicolon()) {
@@ -2935,8 +2933,6 @@ module ts {
29352933
node.type = parseTypeAnnotation();
29362934

29372935
// Issue any initializer-related errors on the equals token
2938-
var initializerStart = scanner.getTokenPos();
2939-
var initializerFirstTokenLength = scanner.getTextPos() - initializerStart;
29402936
node.initializer = parseInitializer(/*inParameter*/ false, noIn);
29412937

29422938
return finishNode(node);
@@ -2998,7 +2994,6 @@ module ts {
29982994
function parsePropertyMemberDeclaration(pos: number, modifiers: ModifiersArray): Declaration {
29992995
var name = parsePropertyName();
30002996
var flags = modifiers ? modifiers.flags : 0;
3001-
var questionStart = scanner.getTokenPos();
30022997
if (parseOptional(SyntaxKind.QuestionToken)) {
30032998
// Note: this is not legal as per the grammar. But we allow it in the parser and
30042999
// report an error in the grammar checker.
@@ -3031,8 +3026,6 @@ module ts {
30313026
property.name = name;
30323027
property.type = parseTypeAnnotation();
30333028

3034-
var initializerStart = scanner.getTokenPos();
3035-
var initializerFirstTokenLength = scanner.getTextPos() - initializerStart;
30363029
property.initializer = parseInitializer(/*inParameter*/ false);
30373030
parseSemicolon();
30383031

@@ -3324,7 +3317,6 @@ module ts {
33243317
var pos = getNodePos();
33253318
var modifiers = parseModifiers(modifierContext);
33263319
if (token === SyntaxKind.ExportKeyword) {
3327-
var modifiersEnd = scanner.getStartPos();
33283320
nextToken();
33293321
if (parseOptional(SyntaxKind.EqualsToken)) {
33303322
return parseExportAssignmentTail(pos, modifiers);

‎tests/baselines/reference/spaceBeforeQuestionMarkInPropertyAssignment.errors.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
tests/cases/compiler/spaceBeforeQuestionMarkInPropertyAssignment.ts(1,12): error TS1162: An object member cannot be declared optional.
2+
3+
4+
==== tests/cases/compiler/spaceBeforeQuestionMarkInPropertyAssignment.ts (1 errors) ====
5+
var x = {x ?: 1} // should not crash
6+
~
7+
!!! error TS1162: An object member cannot be declared optional.

‎tests/cases/compiler/spaceBeforeQuestionMarkInPropertyAssignment.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
var x = {x ?: 1} // should not crash

0 commit comments

Comments
 (0)
0