fix: comments

shyim · shyim · commit 0d5967bf5ba7 · 2022-10-28T07:15:09.000Z
diff --git a/commands/local_server_start.go b/commands/local_server_start.go
@@ -67,7 +67,7 @@ var localServerStartCmd = &console.Command{
 		&console.BoolFlag{Name: "no-humanize", Usage: "Do not format JSON logs"},
 		&console.StringFlag{Name: "p12", Usage: "Name of the file containing the TLS certificate to use in p12 format"},
 		&console.BoolFlag{Name: "no-tls", Usage: "Use HTTP instead of HTTPS"},
-		&console.BoolFlag{Name: "use-gzip", Usage: "Use GZIP", DefaultValue: false},
+		&console.BoolFlag{Name: "use-gzip", Usage: "Use GZIP"},
 	},
 	Action: func(c *console.Context) error {
 		ui := terminal.SymfonyStyle(terminal.Stdout, terminal.Stdin)
diff --git a/local/http/http.go b/local/http/http.go
@@ -66,9 +66,13 @@ var gzipContentTypes = []string{
 	"text/csv",
 	"text/javascript",
 	"text/css",
+	"text/xml",
 	"application/json",
 	"application/javascript",
 	"application/vnd.api+json",
+	"application/atom+xml",
+	"application/rss+xml",
+	"image/svg+xml",
 }
 
 // Start starts the server
@@ -79,17 +83,17 @@ func (s *Server) Start(errChan chan error) (int, error) {
 	}
 	s.serverPort = strconv.Itoa(port)
 
-	gzipWrapper, err := gziphandler.GzipHandlerWithOpts(gziphandler.ContentTypes(gzipContentTypes))
-
-	if err != nil {
-		return port, err
-	}
-
 	var proxyHandler http.Handler
 
 	proxyHandler = http.HandlerFunc(s.ProxyHandler)
 
 	if s.UseGzip {
+		gzipWrapper, err := gziphandler.GzipHandlerWithOpts(gziphandler.ContentTypes(gzipContentTypes))
+
+		if err != nil {
+			return port, errors.WithStack(err)
+		}
+
 		proxyHandler = gzipWrapper(proxyHandler)
 	}
 
