Fix minor bug in request factory (tableau#544)

guodah · Chris Shin · commit 0f6a5bceed17 · 2019-12-19T13:21:03.000-08:00
* fix minor bug in request_factory

* make materializeNow an optional argument to be consistent with the server side code

* factor
diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py
@@ -480,14 +480,15 @@ def update_req(self, workbook_item):
         if workbook_item.owner_id:
             owner_element = ET.SubElement(workbook_element, 'owner')
             owner_element.attrib['id'] = workbook_item.owner_id
-        if workbook_item.materialized_views_config['materialized_views_enabled'] \
-                and workbook_item.materialized_views_config['run_materialization_now']:
+        if workbook_item.materialized_views_config is not None and \
+                'materialized_views_enabled' in workbook_item.materialized_views_config:
             materialized_views_config = workbook_item.materialized_views_config
             materialized_views_element = ET.SubElement(workbook_element, 'materializedViewsEnablementConfig')
             materialized_views_element.attrib['materializedViewsEnabled'] = str(materialized_views_config
                                                                                 ["materialized_views_enabled"]).lower()
-            materialized_views_element.attrib['materializeNow'] = str(materialized_views_config
-                                                                      ["run_materialization_now"]).lower()
+            if "run_materialization_now" in materialized_views_config:
+                materialized_views_element.attrib['materializeNow'] = str(materialized_views_config
+                                                                          ["run_materialization_now"]).lower()
 
         return ET.tostring(xml_request)
 
