fix(eslint-plugin): [no-unsafe-call] fix incorrect selector (typescript-eslint#1826)

bradzacher · web-flow · commit 8ec53a3579fc · 2020-03-30T17:04:10.000-07:00
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-call.ts b/packages/eslint-plugin/src/rules/no-unsafe-call.ts
@@ -41,7 +41,7 @@ export default util.createRule<[], MessageIds>({
     }
 
     return {
-      ':matches(CallExpression, OptionalCallExpression) > :not(Import)'(
+      ':matches(CallExpression, OptionalCallExpression) > :not(Import).callee'(
         node: Exclude<TSESTree.LeftHandSideExpression, TSESTree.Import>,
       ): void {
         checkCall(node, node, 'unsafeCall');
diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts
@@ -21,6 +21,11 @@ ruleTester.run('no-unsafe-call', rule, {
     'new Map()',
     'String.raw`foo`',
     'const x = import("./foo");',
+    // https://github.com/typescript-eslint/typescript-eslint/issues/1825
+    `
+      let foo: any = 23;
+      String(foo); // ERROR: Unsafe call of an any typed value
+    `,
   ],
   invalid: [
     ...batchedSingleLineTests({

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export default util.createRule<[], MessageIds>({`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`return {`
`44`		`- ':matches(CallExpression, OptionalCallExpression) > :not(Import)'(`
	`44`	`+ ':matches(CallExpression, OptionalCallExpression) > :not(Import).callee'(`
`45`	`45`	`node: Exclude<TSESTree.LeftHandSideExpression, TSESTree.Import>,`
`46`	`46`	`): void {`
`47`	`47`	`checkCall(node, node, 'unsafeCall');`