Fixed retry prompting in NumberPrompt by adding await (microsoft#302)

Zerryth · web-flow · commit 6c157756507d · 2019-08-19T14:58:03.000-07:00
* Fixed retry prompting in NumberPrompt by adding await

* ran black on libraries
diff --git a/libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/number_prompt.py b/libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/number_prompt.py
@@ -40,7 +40,7 @@ async def on_prompt(
             raise TypeError("NumberPrompt.on_prompt(): options cannot be None.")
 
         if is_retry and options.retry_prompt is not None:
-            turn_context.send_activity(options.retry_prompt)
+            await turn_context.send_activity(options.retry_prompt)
         elif options.prompt is not None:
             await turn_context.send_activity(options.prompt)
 
diff --git a/libraries/botbuilder-dialogs/tests/test_number_prompt.py b/libraries/botbuilder-dialogs/tests/test_number_prompt.py
@@ -125,9 +125,6 @@ async def exec_test(turn_context: TurnContext) -> None:
         test_flow4 = await test_flow3.send("Give me twenty meters of cable")
         await test_flow4.assert_reply("You asked me for '20' meters of cable.")
 
-    # TODO: retry_prompt in NumberPrompt appears to be broken
-    # It when NumberPrompt fails to receive a number, it retries, prompting
-    # with the prompt and not retry prompt in options
     async def test_number_prompt_retry(self):
         async def exec_test(turn_context: TurnContext) -> None:
             dialog_context: DialogContext = await dialogs.create_context(turn_context)
@@ -161,14 +158,11 @@ async def exec_test(turn_context: TurnContext) -> None:
         dialogs.add(number_prompt)
 
         step1 = await adapter.send("hello")
-        await step1.assert_reply("Enter a number.")
-        # TODO: something is breaking in the validators or retry prompt
-        # where it does not accept the 2nd answer after reprompting the user
-        # for another value
-        # step3 = await step2.send("hello")
-        # step4 = await step3.assert_reply("You must enter a number.")
-        # step5 = await step4.send("64")
-        # await step5.assert_reply("Bot received the number '64'.")
+        step2 = await step1.assert_reply("Enter a number.")
+        step3 = await step2.send("hello")
+        step4 = await step3.assert_reply("You must enter a number.")
+        step5 = await step4.send("64")
+        await step5.assert_reply("Bot received the number '64'.")
 
     async def test_number_uses_locale_specified_in_constructor(self):
         # Create new ConversationState with MemoryStorage and register the state as middleware.
@@ -272,13 +266,12 @@ async def validator(prompt_context: PromptValidatorContext):
 
         step1 = await adapter.send("hello")
         step2 = await step1.assert_reply("Enter a number.")
-        await step2.send("150")
-        # TODO: something is breaking in the validators or retry prompt
-        # where it does not accept the 2nd answer after reprompting the user
-        # for another value
-        # step4 = await step3.assert_reply("You must enter a positive number less than 100.")
-        # step5 = await step4.send("64")
-        # await step5.assert_reply("Bot received the number '64'.")
+        step3 = await step2.send("150")
+        step4 = await step3.assert_reply(
+            "You must enter a positive number less than 100."
+        )
+        step5 = await step4.send("64")
+        await step5.assert_reply("Bot received the number '64'.")
 
     async def test_float_number_prompt(self):
         async def exec_test(turn_context: TurnContext) -> None:
