8000 Added SeverityEnum (#289) · sherlock666/botbuilder-python@2d5b9d1 · GitHub
[go: up one dir, main page]
Skip to content

Commit 2d5b9d1

Browse files
axelsrzaxelsrz
authored
Added SeverityEnum (microsoft#289)
1 parent 40b979c commit 2d5b9d1

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

‎libraries/botbuilder-applicationinsights/botbuilder/applicationinsights/application_insights_telemetry_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from applicationinsights import TelemetryClient # pylint: disable=no-name-in-module
88
from botbuilder.core.bot_telemetry_client import (
99
BotTelemetryClient,
10+
Severity,
1011
TelemetryDataPointType,
1112
)
1213
from .integration_post_data import IntegrationPostData
@@ -168,7 +169,7 @@ def track_metric(
168169
)
169170

170171
def track_trace(
171-
self, name: str, properties: Dict[str, object] = None, severity=None
172+
self, name: str, properties: Dict[str, object] = None, severity: Severity = None
172173
):
173174
"""
174175
Sends a single trace statement.

‎libraries/botbuilder-core/botbuilder/core/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from .bot_framework_adapter import BotFrameworkAdapter, BotFrameworkAdapterSettings
1515
from .bot_state import BotState
1616
from .bot_state_set import BotStateSet
17-
from .bot_telemetry_client import BotTelemetryClient
17+
from .bot_telemetry_client import BotTelemetryClient, Severity
1818
from .card_factory import CardFactory
1919
from .conversation_state import ConversationState
2020
from .intent_score import IntentScore
@@ -57,6 +57,7 @@
5757
"NullTelemetryClient",
5858
"Recognizer",
5959
"RecognizerResult",
60+
"Severity",
6061
"ShowTypingMiddleware",
6162
"StatePropertyAccessor",
6263
"StatePropertyInfo",

‎libraries/botbuilder-core/botbuilder/core/bot_telemetry_client.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@
77
from enum import Enum
88

99

10+
class Severity(Enum):
11+
verbose = 0
12+
information = 1
13+
warning = 2
14+
error = 3
15+
critical = 4
16+
17+
1018
class TelemetryDataPointType(Enum):
1119
measurement = 0
1220
aggregation = 1
@@ -105,7 +113,7 @@ def track_metric(
105113
)
106114

107115
@abstractmethod
108-
def track_trace(self, name, properties=None, severity=None):
116+
def track_trace(self, name, properties=None, severity: Severity = None):
109117
"""
110118
Sends a single trace statement.
111119
:param name: the trace statement.\n

‎libraries/botbuilder-core/botbuilder/core/null_telemetry_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import traceback
55
from typing import Dict
6-
from .bot_telemetry_client import BotTelemetryClient, TelemetryDataPointType
6+
from .bot_telemetry_client import BotTelemetryClient, TelemetryDataPointType, Severity
77

88

99
class NullTelemetryClient(BotTelemetryClient):
@@ -90,7 +90,7 @@ def track_metric(
9090
"""
9191
return
9292

93-
def track_trace(self, name, properties=None, severity=None):
93+
def track_trace(self, name, properties=None, severity: Severity = None):
9494
"""
9595
Sends a single trace statement.
9696
:param name: the trace statement.\n

0 commit comments

Comments
 (0)
0