Add secretsmanager to LOCALSTACK_PORTS constant in LocalstackDocker (localstack#1351)

ausarb · whummer · commit f20741006897 · 2019-06-10T20:11:09.000+02:00
diff --git a/localstack/ext/java/src/main/java/cloud/localstack/docker/Container.java b/localstack/ext/java/src/main/java/cloud/localstack/docker/Container.java
@@ -21,7 +21,7 @@ public class Container {
     private static final Logger LOG = Logger.getLogger(Container.class.getName());
 
     private static final String LOCALSTACK_NAME = "localstack/localstack";
-    private static final String LOCALSTACK_PORTS = "4567-4583";
+    private static final String LOCALSTACK_PORTS = "4567-4584";
 
     private static final int MAX_PORT_CONNECTION_ATTEMPTS = 10;
 
diff --git a/localstack/ext/java/src/test/java/cloud/localstack/docker/BasicDockerFunctionalityTest.java b/localstack/ext/java/src/test/java/cloud/localstack/docker/BasicDockerFunctionalityTest.java
@@ -22,6 +22,9 @@
 import com.amazonaws.services.s3.model.ObjectListing;
 import com.amazonaws.services.s3.model.PutObjectRequest;
 import com.amazonaws.services.s3.model.S3Object;
+import com.amazonaws.services.secretsmanager.AWSSecretsManager;
+import com.amazonaws.services.secretsmanager.model.CreateSecretRequest;
+import com.amazonaws.services.secretsmanager.model.GetSecretValueRequest;
 import com.amazonaws.services.sqs.AmazonSQS;
 import com.amazonaws.services.sqs.model.CreateQueueRequest;
 import com.amazonaws.services.sqs.model.ListQueuesResult;
@@ -50,6 +53,22 @@ public class BasicDockerFunctionalityTest {
         TestUtils.setEnv("AWS_CBOR_DISABLE", "1");
     }
 
+    @org.junit.Test
+    @org.junit.jupiter.api.Test
+    public void testSecretsManager() throws Exception {
+        AWSSecretsManager secretsManager = DockerTestUtils.getClientSecretsManager();
+
+        CreateSecretRequest createSecretRequest = new CreateSecretRequest();
+        createSecretRequest.setName("my-secret-name");
+        createSecretRequest.setSecretString("this is a secret thing");
+        secretsManager.createSecret(createSecretRequest);
+
+        GetSecretValueRequest getSecretValueRequest = new GetSecretValueRequest().withSecretId("my-secret-name");
+        String result = secretsManager.getSecretValue(getSecretValueRequest).getSecretString();
+        Assertions.assertThat(result).isEqualTo("this is a secret thing");
+
+    }
+
     @org.junit.Test
     @org.junit.jupiter.api.Test
     public void testKinesis() throws Exception {
diff --git a/localstack/ext/java/src/test/java/cloud/localstack/docker/ContainerTest.java b/localstack/ext/java/src/test/java/cloud/localstack/docker/ContainerTest.java
@@ -57,6 +57,7 @@ public void createLocalstackContainerWithRandomPorts() throws Exception {
             assertNotEquals(4567, container.getExternalPortFor(4567));
             assertNotEquals(4575, container.getExternalPortFor(4575));
             assertNotEquals(4583, container.getExternalPortFor(4583));
+            assertNotEquals(4584, container.getExternalPortFor(4584));
         }
         finally {
             container.stop();
@@ -74,6 +75,7 @@ public void createLocalstackContainerWithStaticPorts() throws Exception {
             assertEquals(4567, container.getExternalPortFor(4567));
             assertEquals(4575, container.getExternalPortFor(4575));
             assertEquals(4583, container.getExternalPortFor(4583));
+            assertEquals(4584, container.getExternalPortFor(4584));
         }
         finally {
             container.stop();
