8000 add slight delay before test screenshot so p5 has time for first render · shader-park/shader-park-core@7242e6c · GitHub
[go: up one dir, main page]

Skip to content

Commit 7242e6c

Browse files
committed
add slight delay before test screenshot so p5 has time for first render
1 parent 9e8a69e commit 7242e6c

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

package-lock.json

Lines changed: 15 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
"@rollup/plugin-node-resolve": "^15.2.1",
7070
"chai": "^4.3.8",
7171
"mocha": "^10.2.0",
72+
"p5": "^1.7.0",
7273
"png-js": "^1.0.0",
7374
"puppeteer": "^21.1.0",
7475
"rollup": "^3.28.1",

test/p5Examples/basicP5Test.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<meta charset="utf-8" />
55
<!-- keep the line below for OpenProcessing compatibility -->
66
<!-- <script src="https://openprocessing.org/openprocessing_sketch.js"></script> -->
7-
<script src="https://cdn.jsdelivr.net/npm/p5@1.7.0/lib/p5.js"></script>
7+
<script src="../../node_modules/p5/lib/p5.js"></script>
88
<script type="module" src="../../dist/shader-park-p5.js"></script>
99
<script>
1010
let sdf;

test/render.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@ describe('Compiling, rendering, checking pixels', () => {
119119
logs.push(msg);
120120
});
121121
await page.goto(pagename);
122+
// For some reason p5 hasn't rendered yet, so it needs extra time
123+
await page.waitForTimeout(50);
122124
await page.screenshot({ path: outpath, fullPage: true });
123125
for (const perr of pageErrors) {
124126
assert.fail(`Page javascript error: ${perr}`);

0 commit comments

Comments
 (0)
0