8000 Calculation of maximum order for HOA does not distinguish between even/odd numer of secondary sources · Issue #105 · sfstoolbox/sfs-python · GitHub
[go: up one dir, main page]
Skip to content
8000

Calculation of maximum order for HOA does not distinguish between even/odd numer of secondary sources #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spors opened this issue Mar 6, 2019 · 2 comments
Closed

Calculation of maximum order for HOA does not distinguish between even/odd numer of secondary sources #105

spors opened this issue Mar 6, 2019 · 2 comments
Assignees
@spors
Labels
bug enhancement

Comments

@spors
Copy link
Member
spors commented Mar 6, 2019

See

sfs-python/sfs/mono/drivingfunction.py

Lines 795 to 797 in 3ae7a9f

def _max_order_circular_harmonics(N, max_order):
"""Compute order of 2D HOA."""
return N // 2 if max_order is None else max_order

@spors spors self-assigned this Mar 6, 2019
@mgeier
Copy link
Member
mgeier commented Mar 6, 2019

This is moved to util.max_order_circular_harmonics() in #45 and changed to

return (N - 1) // 2

This should fix the issue, right?

@spors
Copy link
Member Author
spors commented Mar 7, 2019

Yes that fixes the issue!

@spors spors closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spors spors

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgeier @spors
0