This repository was archived by the owner on Jan 28, 2025. It is now read-only.
fix: Change defaultNextLambda removalPolicy from DESTROY to RETAIN #2420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handler Size Report
Base Handler Sizes (kB) (commit e7af519){
"Lambda": {
"Default Lambda": {
"Standard": 1578,
"Minified": 692
},
"Image Lambda": {
"Standard": 1542,
"Minified": 830
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1588,
"Minified": 698
},
"Default Lambda V2": {
"Standard": 1580,
"Minified": 694
},
"API Lambda": {
"Standard": 634,
"Minified": 318
},
"Image Lambda": {
"Standard": 1550,
"Minified": 835
},
"Regeneration Lambda": {
"Standard": 1233,
"Minified": 566
},
"Regeneration Lambda V2": {
"Standard": 1307,
"Minified": 596
}
}
}New Handler Sizes (kB) (commit 9922c1e){
"Lambda": {
"Default Lambda": {
"Standard": 1578,
"Minified": 692
},
"Image Lambda": {
"Standard": 1542,
"Minified": 830
}
},
"Lambda@Edge": {
"Default Lambda": {
"Standard": 1588,
"Minified": 698
},
"Default Lambda V2": {
"Standard": 1580,
"Minified": 694
},
"API Lambda": {
"Standard": 634,
"Minified": 318
},
"Image Lambda": {
"Standard": 1550,
"Minified": 835
},
"Regeneration Lambda": {
"Standard": 1233,
"Minified": 566
},
"Regeneration Lambda V2": {
"Standard": 1307,
"Minified": 596
}
}
} |
Codecov Report
@@ Coverage Diff @@
## master #2420 +/- ##
=======================================
Coverage 83.59% 83.59%
=======================================
Files 102 102
Lines 3706 3706
Branches 1188 1188
=======================================
Hits 3098 3098
Misses 596 596
Partials 12 12
Continue to review full report at Codecov.
|
dphang
approved these changes
Apr 20, 2022
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request i
2C03
s queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
As per this issue, there are times during builds where the old
defaultNextLambdagets destroyed before the build has completed and incoming traffic is served a 503 error for pages that have not yet finished static generation.Solution:
Change the
removalPolicyofDESTROYon thedefaultNextLambdatoRETAIN, and in a separate PR, trigger a function to clean up old Lambda's after a build has completed successfully.