8000 development dependencies are not excluded · Issue #5396 · serverless/serverless · GitHub
[go: up one dir, main page]

Skip to content
development dependencies are not excluded #5396
@sixmen

Description

@sixmen

This is a Bug Report

Description

Sample program is:

$ serverless --version
1.32.0

$ cat serverless.yml 
service: test

provider:
  name: aws
  runtime: nodejs8.10
  memorySize: 256

functions:
  app:
    handler: app.handler

plugins:
  - serverless-plugin-typescript

$ cat package.json 
{
  "devDependencies": {
    "serverless-plugin-typescript": "^1.1.5"
  }
}

When I run serverless package, I hope the package does not include any module, but it has many modules include typescript module.

node_modules tree is:

$ npm ls
/tmp/sl
└─┬ serverless-plugin-typescript@1.1.5
  ├─┬ fs-extra@5.0.0
  │ ├── graceful-fs@4.1.11
  │ ├─┬ jsonfile@4.0.0
  │ │ └── graceful-fs@4.1.11 deduped
  │ └── universalify@0.1.2
  ├─┬ globby@7.1.1
  │ ├─┬ array-union@1.0.2
  │ │ └── array-uniq@1.0.3
  │ ├─┬ dir-glob@2.0.0
  │ │ ├── arrify@1.0.1
  │ │ └─┬ path-type@3.0.0
  │ │   └── pify@3.0.0 deduped
  │ ├─┬ glob@7.1.3
  │ │ ├── fs.realpath@1.0.0
  │ │ ├─┬ inflight@1.0.6
  │ │ │ ├── once@1.4.0 deduped
  │ │ │ └── wrappy@1.0.2
  │ │ ├── inherits@2.0.3
  │ │ ├─┬ minimatch@3.0.4
  │ │ │ └─┬ brace-expansion@1.1.11
  │ │ │   ├── balanced-match@1.0.0
  │ │ │   └── concat-map@0.0.1
  │ │ ├─┬ once@1.4.0
  │ │ │ └── wrappy@1.0.2 deduped
  │ │ └── path-is-absolute@1.0.1
  │ ├── ignore@3.3.10
  │ ├── pify@3.0.0
  │ └── slash@1.0.0
  ├── lodash@4.17.11
  └── typescript@2.9.2

but zipService.excludeDevDependencies excludes only serverless-plugin-typescript.

Serverless: Excluding development dependencies...
{ exclude: 
   [ '.git/**',
     '.gitignore',
     '.DS_Store',
     'npm-debug.log',
     'serverless.yml',
     'serverless.yaml',
     'serverless.json',
     'serverless.js',
     '.serverless/**',
     '.serverless_plugins/**',
     '/tmp/sl/.build/.serverless_plugins',
     'node_modules/serverless-plugin-typescript/**' ],
  include: [] }

Is this a bug, or am I missing something?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0