8000 feat(web): introduced interaction to Drag.the(element).to(dropZone) by jan-molak · Pull Request #2663 · serenity-js/serenity-js · GitHub
[go: up one dir, main page]
Skip to content

feat(web): introduced interaction to Drag.the(element).to(dropZone) #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

feat(web): introduced interaction to Drag.the(element).to(dropZone) #2663

wants to merge 14 commits into from

Conversation

jan-molak
Copy link
Member

#2583 by @TurekBot updated to support WebdriverIO 9

TurekBot and others added 13 commits October 27, 2024 04:38
@TurekBot
test(web): add test for forthcoming Drag interaction
1f7e76e 
I borrowed the drag and drop example html from MDN. Conveniently, it logs all the drag events.

Related tickets: #2132
@TurekBot
feat(web): add dragTo() to PageElement
41867b8 
Once implemented, this will allow you to drag elements to other elements.

Related tickets: #2132
@TurekBot
feat(web): implement dragTo for Playwright
9ec8dd0 
Related tickets: #2132
@TurekBot
feat(web): create Drag interaction
35391eb 
I based it loosely off the `Switch` interaction

Related tickets: #2132
@TurekBot
feat(web): implement dragTo() for Protractor
723fd1f 
I have no experience with Protractor. However, this implementation is pretty close to the one Jan suggested in #177, so maybe I got it right? Who knows.
@TurekBot
feat(web): implement dragTo() for WebdriverIO
036c930 
I have no experience with WebdriverIO. However, other people in the bug ticket webdriverio/webdriverio#8022, say this works, so maybe it does?
@TurekBot
style(web): remove semi-colon for consistency
36af232
@TurekBot
test(web): update PageElement invocation locations to fix tests
299ddb5 
Refs: #2583 (comment)
@TurekBot
fix(web): see if Wait instead of Ensure fixes failing protractor test
47b6ebc 
Also check for the drag events that get output in this specific example.

Refs: https://github.com/serenity-js/serenity-js/actions/runs/11537779951/job/32115590925?pr=2583#step:8:3282
@TurekBot
style(web): use single instead of double quotes
9226d75 
Refs: https://github.com/serenity-js/serenity-js/actions/runs/11538026633/job/32116051893?pr=2583#step:8:16
@TurekBot
style(web): autoformat PageElement.spec.ts
6ecaf13
@TurekBot
refactor(web): get better feedback on if events are happening or not
c439173 
Refs: https://github.com/serenity-js/serenity-js/actions/runs/11538036848/job/32116089270?pr=2583#step:8:3282
@jan-molak
Merge branch 'drag-interaction-attempt-1' of github.com:TurekBot/sere…
ca88835 
…nity-js into TurekBot-drag-interaction-attempt-1
@jan-molak jan-molak mentioned this pull request Dec 26, 2024
Draft
@jan-molak jan-molak marked this pull request as draft December 26, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-molak @TurekBot
0