8000 fix: adapt for latest @octokit/rest to remove deprecation warnings by immanuel192 · Pull Request #177 · semantic-release/github · GitHub
[go: up one dir, main page]

Skip to content

fix: adapt for latest @octokit/rest to remove deprecation warnings #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

immanuel192
Copy link
Contributor
  • The goal of this PR to correct the deprecated param from octokit/rest.
  • Calling with deprecated param will get this warning
{ Deprecation: [@octokit/rest] "number" parameter is deprecated for ".pullRequests.listCommits()". Use "pull_number" instead
    at Object.keys.forEach.key (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:73:26)
    at Array.forEach (<anonymous>)
    at Object.patchedMethod [as listCommits] (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:69:26)
    at pFilter (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@semantic-release/github/lib/success.js:54:36)
    at pMap (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/p-filter/index.js:5:46)
    at Promise.resolve.then.el (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/p-map/index.js:46:16) name: 'Deprecation' }
{ Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.createComment()". Use "issue_number" instead
    at Object.keys.forEach.key (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:73:26)
    at Array.forEach (<anonymous>)
    at Object.patchedMethod [as createComment] (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:69:26)
    at Promise.all.uniqBy.map (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@semantic-release/github/lib/success.js:86:37)
    at Array.map (<anonymous>)
    at module.exports (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@semantic-release/github/lib/success.js:74:45) name: 'Deprecation' }

Copy link
Member
@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Trung!

@gr2m gr2m changed the title refactor: update param to call octokit fix: adapt for latest @octokit/rest to remove deprecation warnings Apr 25, 2019
@gr2m gr2m merged commit fa677fa into semantic-release:master Apr 25, 2019
@semantic-release-bot
Copy link
Collaborator
semantic-release-bot commented Apr 25, 2019

🎉 This PR is included in version 5.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0