8000 fix: adapt for latest @octokit/rest to remove deprecation warnings by immanuel192 · Pull Request #177 · semantic-release/github · GitHub
[go: up one dir, main page]
Skip to content

fix: adapt for latest @octokit/rest to remove deprecation warnings #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

fix: adapt for latest @octokit/rest to remove deprecation warnings #177

merged 1 commit into from
Apr 25, 2019

Conversation

immanuel192
Copy link
Contributor
  • The goal of this PR to correct the deprecated param from octokit/rest.
  • Calling with deprecated param will get this warning
{ Deprecation: [@octokit/rest] "number" parameter is deprecated for ".pullRequests.listCommits()". Use "pull_number" instead
    at Object.keys.forEach.key (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:73:26)
    at Array.forEach (<anonymous>)
    at Object.patchedMethod [as listCommits] (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:69:26)
    at pFilter (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@semantic-release/github/lib/success.js:54:36)
    at pMap (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/p-filter/index.js:5:46)
    at Promise.resolve.then.el (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/p-map/index.js:46:16) name: 'Deprecation' }
{ Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.createComment()". Use "issue_number" instead
    at Object.keys.forEach.key (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:73:26)
    at Array.forEach (<anonymous>)
    at Object.patchedMethod [as createComment] (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@octokit/rest/plugins/register-endpoints/register-endpoints.js:69:26)
    at Promise.all.uniqBy.map (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@semantic-release/github/lib/success.js:86:37)
    at Array.map (<anonymous>)
    at module.exports (/Users/sbtrung/.nvm/versions/node/v10.12.0/lib/node_modules/semantic-release/node_modules/@semantic-release/github/lib/success.js:74:45) name: 'Deprecation' }

gr2m
gr2m approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member
@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Trung!

@gr2m gr2m changed the title refactor: update param to call octokit fix: adapt for latest @octokit/rest to remove deprecation warnings Apr 25, 2019
@gr2m gr2m merged commit fa677fa into semantic-release:master Apr 25, 2019
@semantic-release-bot
Copy link
Collaborator
semantic-release-bot commented Apr 25, 2019 •
edited by hearts bot
Loading

🎉 This PR is included in version 5.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m mentioned this pull request Apr 25, 2019
Closed
@immanuel192 immanuel192 deleted the feature/fix-octokit-rest-param-deprecated branch April 25, 2019 05:12
pvdlg pushed a commit that referenced this pull request May 8, 2019
@immanuel192 @pvdlg
fix: adapt for latest @octokit/rest to remove deprecation warnings (#177
f0e3a1f 
)
pvdlg pushed a commit that referenced this pull request May 8, 2019
@immanuel192 @pvdlg
fix: adapt for latest @octokit/rest to remove deprecation warnings (#177
e154f69 
)
pvdlg pushed a commit that referenced this pull request May 9, 2019
@immanuel192 @pvdlg
fix: adapt for latest @octokit/rest to remove deprecation warnings (#177
b2bc352 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@immanuel192 @semantic-release-bot @gr2m
0