#97 $().filter("") returns empty set

acdcjunior · acdcjunior · commit de675bdcfa9b · 2016-01-23T18:04:20.000-02:00
diff --git a/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/filterfunction/FilterPredicateFunctionTest.java b/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/filterfunction/FilterPredicateFunctionTest.java
@@ -35,7 +35,7 @@ public class FilterPredicateFunctionTest {
     FilterPredicateFunction filterPredicateFunction = new FilterPredicateFunction();
 
     @Test
-    public void null_predicate__should_return_EMPTY_elements() {
+    public void null_predicate__should_return_EMPTY_element_set() {
         // given
         SeleniumQueryObject targetSQO = createStubSeleniumQueryObjectWithAtLeastOneElement();
         // when
diff --git a/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/filterfunction/FilterSelectorFunctionTest.java b/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/filterfunction/FilterSelectorFunctionTest.java
@@ -23,8 +23,16 @@ public void null_selector__should_return_EMPTY_element_set() {
         assertThat(resultSQO.get(), empty());
     }
 
-    // TODO filter(this, null) --> should return empty
-    // TODO filter(this, "") --> should return empty
+    @Test
+    public void emptyString_selector__should_return_EMPTY_element_set() {
+        // given
+        SeleniumQueryObject targetSQO = createStubSeleniumQueryObjectWithAtLeastOneElement();
+        // when
+        SeleniumQueryObject resultSQO = filterSelectorFunction.filter(targetSQO, "");
+        // then
+        assertThat(resultSQO.get(), empty());
+    }
+
     // TODO filter(this, "selector") --> should keep everyone that matches the isFunction("selector")
 
 }
