resultSQO should have same WebDriver as targetSQO - #97

acdcjunior · acdcjunior · commit cf065f8a8b38 · 2015-12-29T14:55:28.000-02:00
diff --git a/src/main/java/io/github/seleniumquery/functions/jquery/traversing/filtering/FilterFunction.java b/src/main/java/io/github/seleniumquery/functions/jquery/traversing/filtering/FilterFunction.java
@@ -27,7 +27,7 @@ public class FilterFunction {
     public SeleniumQueryObject filter(SeleniumQueryObject seleniumQueryObject, Predicate<WebElement> filterFunction) {
         return instance().create(seleniumQueryObject.getSeleniumQueryFunctions(),
                                  seleniumQueryObject.getWebDriver(),
-                                 seleniumQueryObject.getBy(),
+                                 null,
                                  seleniumQueryObject.get(),
                                  seleniumQueryObject);
     }
diff --git a/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/FilterFunctionTest.java b/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/FilterFunctionTest.java
@@ -66,4 +66,14 @@ public void resultSQO_should_have_same_SQFunctions_as_targetSQO() {
         assertThat(resultSQO.getSeleniumQueryFunctions(), is(targetSQO.getSeleniumQueryFunctions()));
     }
 
+    @Test
+    public void resultSQO_should_have_same_WebDriver_as_targetSQO() {
+        // given
+        SeleniumQueryObject targetSQO = createStubSeleniumQueryObject();
+        // when
+        SeleniumQueryObject resultSQO = filterFunction.filter(targetSQO, NULL_PREDICATE);
+        // then
+        assertThat(resultSQO.getWebDriver(), is(targetSQO.getWebDriver()));
+    }
+
 }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public class FilterFunction {`
`27`	`27`	`public SeleniumQueryObject filter(SeleniumQueryObject seleniumQueryObject, Predicate<WebElement> filterFunction) {`
`28`	`28`	`return instance().create(seleniumQueryObject.getSeleniumQueryFunctions(),`
`29`	`29`	`seleniumQueryObject.getWebDriver(),`
`30`		`- seleniumQueryObject.getBy(),`
	`30`	`+ null,`
`31`	`31`	`seleniumQueryObject.get(),`
`32`	`32`	`seleniumQueryObject);`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,4 +66,14 @@ public void resultSQO_should_have_same_SQFunctions_as_targetSQO() {`
`66`	`66`	`assertThat(resultSQO.getSeleniumQueryFunctions(), is(targetSQO.getSeleniumQueryFunctions()));`
`67`	`67`	`}`
`68`	`68`
	`69`	`+ @Test`
	`70`	`+ public void resultSQO_should_have_same_WebDriver_as_targetSQO() {`
	`71`	`+ // given`
	`72`	`+ SeleniumQueryObject targetSQO = createStubSeleniumQueryObject();`
	`73`	`+ // when`
	`74`	`+ SeleniumQueryObject resultSQO = filterFunction.filter(targetSQO, NULL_PREDICATE);`
	`75`	`+ // then`
	`76`	`+ assertThat(resultSQO.getWebDriver(), is(targetSQO.getWebDriver()));`
	`77`	`+ }`
	`78`	`+`
`69`	`79`	`}`