.quit() now warns instead of throwing exception - closes #80

ricardocarvalhods · acdcjunior · commit 5f57194bbe80 · 2014-11-30T18:45:50.000-02:00
diff --git a/src/main/java/io/github/seleniumquery/browser/driver/SeleniumQueryDriver.java b/src/main/java/io/github/seleniumquery/browser/driver/SeleniumQueryDriver.java
@@ -1,8 +1,9 @@
 package io.github.seleniumquery.browser.driver;
 
 import io.github.seleniumquery.SeleniumQueryConfig;
-import io.github.seleniumquery.SeleniumQueryException;
 import io.github.seleniumquery.browser.driver.builders.*;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.openqa.selenium.WebDriver;
 
 import java.util.concurrent.TimeUnit;
@@ -14,6 +15,8 @@
  */
 public class SeleniumQueryDriver {
 
+    private static final Log LOGGER = LogFactory.getLog(SeleniumQueryDriver.class);
+
     private static final DriverBuilder DEFAULT_DRIVER_BUILDER = new HtmlUnitDriverBuilder();
 
     private DriverBuilder driverBuilder = DEFAULT_DRIVER_BUILDER;
@@ -62,18 +65,19 @@ private void setDriverTimeout() {  // TODO unit test
     }
 
     /**
-     * Quits the WebDriver in use by this seleniumQuery browser.
+     * Quits, if exists, the WebDriver in use by this seleniumQuery browser.
      *
      * @since 0.9.0
      *
      * @return A self reference.
      */
     public SeleniumQueryDriver quit() {
         if (webDriver == null) { // TODO unit test
-            throw new SeleniumQueryException("WebDriver was not initialized, you can't .quit() it.");
+            LOGGER.warn("Called .quit() before initializing WebDriver, nothing was done.");
+        } else {
+            webDriver.quit();
+            webDriver = null;
         }
-        webDriver.quit();
-        webDriver = null;
         return this;
     }
 
