#97 Added TODOs for whats left for $().filter();

acdcjunior · acdcjunior · commit 14c711b0263d · 2016-01-19T23:17:31.000-02:00
diff --git a/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/FilterFunctionTest.java b/src/test/java/io/github/seleniumquery/functions/jquery/traversing/filtering/FilterFunctionTest.java
@@ -20,7 +20,6 @@
 import io.github.seleniumquery.SeleniumQueryObject;
 import org.junit.Test;
 import org.openqa.selenium.WebElement;
-import testinfrastructure.testdouble.Stubs;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.collection.IsIterableContainingInAnyOrder.containsInAnyOrder;
@@ -99,4 +98,8 @@ public boolean apply(WebElement webElement) {
         assertThat(resultSQO.get(), contains(spanOne, spanTwo));
     }
 
+    // TODO filter(this, null) --> should return empty ==> CHANGE THIS FOR THE PREDICATE VERSION ALSO, it is returning the original matched set
+    // TODO filter(this, "") --> should return empty
+    // TODO filter(this, "selector") --> should keep everyone that matches the isFunction("selector")
+
 }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`	`import io.github.seleniumquery.SeleniumQueryObject;`
`21`	`21`	`import org.junit.Test;`
`22`	`22`	`import org.openqa.selenium.WebElement;`
`23`		`-import testinfrastructure.testdouble.Stubs;`
`24`	`23`
`25`	`24`	`import static org.hamcrest.CoreMatchers.is;`
`26`	`25`	`import static org.hamcrest.collection.IsIterableContainingInAnyOrder.containsInAnyOrder;`
`@@ -99,4 +98,8 @@ public boolean apply(WebElement webElement) {`
`99`	`98`	`assertThat(resultSQO.get(), contains(spanOne, spanTwo));`
`100`	`99`	`}`
`101`	`100`
	`101`	`+ // TODO filter(this, null) --> should return empty ==> CHANGE THIS FOR THE PREDICATE VERSION ALSO, it is returning the original matched set`
	`102`	`+ // TODO filter(this, "") --> should return empty`
	`103`	`+ // TODO filter(this, "selector") --> should keep everyone that matches the isFunction("selector")`
	`104`	`+`
`102`	`105`	`}`