8000 Determine if specific constraints for Windows are necessary · Issue #65 · scipy/oldest-supported-numpy · GitHub
[go: up one dir, main page]
Skip to content

Determine if specific constraints for Windows are necessary #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmarmo opened this issue Oct 18, 2022 · 3 comments
Closed

Determine if specific constraints for Windows are necessary #65

cmarmo opened this issue Oct 18, 2022 · 3 comments

Comments

@cmarmo
Copy link
cmarmo commented Oct 18, 2022

Dear maintainers,
I am opening this issue as a follow-up of the discussion started in scikit-learn/scikit-learn#24669 (comment).

I am not sure this is a real issue, but it probably needs some clarification outside the scikit-learn issue where it has been discussed.
I try to sum up my understanding.

There are no specific constraints on numpy versions for Windows on setup.cfg.

They were added in #44, then reverted in #47, after discussions in #45.
Perhaps they are indeed not needed?

Feel free to close if this is not relevant.
Thanks for your attention.
@cmarmo
Copy link
Author
cmarmo commented Oct 20, 2022

Just linking here scikit-learn/scikit-learn#24604

        ERROR: Cannot install numpy==1.21.6 and numpy==1.22.3 because these package versions have conflicting dependencies.

        The conflict is caused by:
            The user requested numpy==1.22.3
            The user requested numpy==1.21.6

Could this be related to scikit-learn using old-supported-numpy but not scipy so different versions of numpy are requested in this particular combination on Windows?

@rgommers
Copy link
Member

Could this be related to scikit-learn using old-supported-numpy but not scipy so different versions of numpy are requested in this particular combination on Windows?

@cmarmo yes indeed, that is exactly it. See scikit-learn/scikit-learn#24604 (comment)

@rgommers
Copy link
Member

This was discussed further and resolved on the linked scikit-learn issue. There's nothing to change here, so I'll close this issue. Thanks @cmarmo!

@rgommers rgommers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgommers @cmarmo
0