8000 [Request] Make new releases compatible with modern scikit-learn · Issue #1071 · scikit-optimize/scikit-optimize · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

[Request] Make new releases compatible with modern scikit-learn #1071

Open
4 of 11 tasks
QuentinSoubeyran opened this issue Oct 1, 2021 · 7 comments
Open
4 of 11 tasks

[Request] Make new releases compatible with modern scikit-learn #1071

QuentinSoubeyran opened this issue Oct 1, 2021 · 7 comments

Comments

@QuentinSoubeyran
Copy link
Contributor
QuentinSoubeyran commented Oct 1, 2021 •
edited
Loading

Making a 0.9 release, compatible with scikit-learn>=0.24, and one with the new features would be nice.

0.9.0 release (Already released) (bugfixes, compatibility with scikit-learn>=0.24):

Unmerged PR:

Unofficial test branch
I have made an unofficial test branch on my fork, unofficial, for testing some of those features. If someone wishes to test features & fixes, one can install from source using

pip install git+https://github.com/QuentinSoubeyran/scikit-optimize.git@unofficial

Warning: If you are using this unofficial branch, before reporting an issue:

  • If the issue is reproducible with the master branch from this repo, open an issue in this repo
  • If not, identify which PR causes the issue, and add a comment in the discussion for this PR

See also:
#1059

EDIT: edited plan to reflect @xmatthias comment
EDIT: edited to reflect release of 0.9.0 version
EDIT: update test branch, formatting
@rigtorp
Copy link
rigtorp commented Oct 4, 2021

I would be happy if only current master with the fix to support sklearn 1.0 #1063 would be released.

@xmatthias
Copy link
Contributor
xmatthias commented Oct 5, 2021 •
edited
Loading

I think there should be a interim 0.8.2 release with current master (call it compatibility release?)

From a projects perspective, it's pretty risky to merge a ton of PR's right before a Release - people testing specific PR's or branches (like requested above) will often not have the edge-cases other users encounter.
So i fear that this approach will delay a release for weeks/months, or worse, result in an unstable 0.9.0 release, as some obtruse compatibility-issues between the PR's might appear.

While current master would be pretty stable as far as i can see (the above PR's don't seem to fix anything that wasn't present in 0.8.1 as well).

@QuentinSoubeyran QuentinSoubeyran changed the title [Request] Make a 0.9 release compatible with modern scikit-learn [Request] Make new releases compatible with modern scikit-learn Oct 5, 2021
@RNarayan73 RNarayan73 mentioned this issue Oct 17, 2021
Merged
@QuentinSoubeyran
Copy link
Contributor Author

@kernc with the release of 0.9.0, feel free to close this. I can also update it to serve as information for people coming on the repo. Though an official, pinned issue would probably be better for that.

@QuentinSoubeyran
Copy link
Contributor Author

@RNarayan73 you should use the above unofficial branch instead of the old mock branch if you want to test un-merged features.

@RNarayan73
Copy link

I tested the multimetric feature in the unofficial branch and it works fine.
Thanks,
Narayan

@RNarayan73 RNarayan73 mentioned this issue Apr 6, 2022
Open
@jmnunezd
Copy link

Thanks! the multi-metric is working for me as well on this branch! hope this can be merge in the future to the main branch

@QuentinSoubeyran
Copy link
Contributor Author

I'm afraid the library hasn't been updated for other a year, so this is unlikely. The last 0.9.0 release is quite dated, and there hasn't been any activity from the maintainers since.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rigtorp @xmatthias @jmnunezd @QuentinSoubeyran @RNarayan73
0