8000 Not using copy in optimizer for specs · scikit-optimize/scikit-optimize@a918650 · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Commit a918650

Browse files
freddyaboultonglouppe
authored andcommitted
Not using copy in optimizer for specs
1 parent 6d16680 commit a918650

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

skopt/optimizer/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ def base_minimize(func, dimensions, base_estimator,
210210
http://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.OptimizeResult.html
211211
"""
212212
specs = {"args": copy.deepcopy(locals()),
213-
"function": copy.deepcopy(inspect.currentframe().f_code.co_name)}
213+
"function": "base_minimize"}
214214

215215
acq_optimizer_kwargs = {
216216
"n_points": n_points, "n_restarts_optimizer": n_restarts_optimizer,

skopt/optimizer/optimizer.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import warnings
33
from math import log
44
from numbers import Number
5-
import copy
65
import numpy as np
76

87
from scipy.optimize import fmin_l_bfgs_b
@@ -170,7 +169,9 @@ def __init__(self, dimensions, base_estimator="gp",
170169
model_queue_size=None,
171170
acq_func_kwargs=None,
172171
acq_optimizer_kwargs=None):
173-
self.specs = {"args": copy.deepcopy(locals()),
172+
args = locals()
173+
del args['self']
174+
self.specs = {"args": args,
174175
"function": "Optimizer"}
175176
self.rng = check_random_state(random_state)
176177

0 commit comments

Comments
 (0)
0