Ignore underflow in LabelPropagation #9384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with np.errstate(under='ignore'):
...
|
|
The checks can be moved inside |
|
The test should probably use assert_no_warnings
…On 18 Jul 2017 7:05 am, "Utkarsh Upadhyay" ***@***.***> wrote:
The checks can be moved inside self._get_kernel function, right at the
site of the call to the function rbf_kernel. The example in the original
issue can be used as the test case.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9384 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz65rPUyUOOfQtfAyt2Lr44YVivsTUks5sO8yugaJpZM4OZZsT>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9313
What does this implement/fix? Explain your changes.
This pull request fixes issues of underflow and invalid value errors thrown from LabelPropagation, which are expected in certain data topologies. Error settings are temporarily changed to ignore
invalidandundererrors and restored at the end of the function.Any other comments?
It appears that the issue of underflow for RBF and Laplacian kernels may occur for other models as well. I will try to go through SVMs and other models using kernel methods and see if this error appears.