[MRG+1] Improved docstring for permutation_test_score (#8379 and #8564) #8569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks |
raghavrv
suggested changes
Mar 12, 2017
sklearn/cross_validation.py
Outdated
| rather a loss function (i.e. when lower is better such as with | ||
| `mean_squared_error`) then this is actually the complement of the | ||
| p-value: 1 - p-value. | ||
| The p-value, which approximates the probability the score would be |
| rather a loss function (i.e. when lower is better such as with | ||
| `mean_squared_error`) then this is actually the complement of the | ||
| p-value: 1 - p-value. | ||
| The p-value, which approximates the probability the score would be |
|
Thanks for the correction. Changes ready. |
|
Thanks @leereeves! |
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docstring for permutation_test_score (pvalue section) to remove an outdated reference to loss functions (#8564) and explain why the p-value is never zero (#8379) in a way that is hopefully accessible to non machine-learning experts.
Changed in two files because I changed both the deprecated and new locations of the function.