10000 [MRG] FIX/TST fix variable called in tree test by glemaitre · Pull Request #8562 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] FIX/TST fix variable called in tree test #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2017
Merged

[MRG] FIX/TST fix variable called in tree test #8562

merged 1 commit into from
Mar 9, 2017

Conversation

glemaitre
Copy link
Member

Reference Issue

None

What does this implement/fix? Explain your changes.

clf was called instead of reg in the test. It did not crash since clf was declared in the previous for loop.

Any other comments?

@glemaitre glemaitre changed the title [MRG] FIX/TST fix bug variable name for pure test [MRG] FIX/TST fix variable called in tree test Mar 9, 2017
@lesteve
Copy link
Member
lesteve commented Mar 9, 2017

:-S good catch, let's wait for the CIs to come back green and merge this one.

@lesteve lesteve merged commit 603ff1a into scikit-learn:master Mar 9, 2017
@lesteve
Copy link
Member
lesteve commented Mar 9, 2017

Merging, thanks!

@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
@glemaitre @herilalaina
FIX/TST fix bug variable name for pure test (scikit-learn#8562)
24331f3
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
@glemaitre
FIX/TST fix bug variable name for pure test (scikit-learn#8562)
a97ecd7
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@glemaitre @Sundrique
FIX/TST fix bug variable name for pure test (scikit-learn#8562)
5fdf30e
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@glemaitre @NelleV
FIX/TST fix bug variable name for pure test (scikit-learn#8562)
4f2dbb9
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@glemaitre @paulha
FIX/TST fix bug variable name for pure test (scikit-learn#8562)
2835515
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@glemaitre @maskani-moh
FIX/TST fix bug variable name for pure test (scikit-learn#8562)
3a64dbd
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@glemaitre
FIX/TST fix bug variable name for pure test (scikit-learn#8562)
50ec90d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemaitre @lesteve
0