8000 [MRG + 2] Correct figure number + matplotlib 2 by mathurinm · Pull Request #8483 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG + 2] Correct figure number + matplotlib 2 #8483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2017
Merged

[MRG + 2] Correct figure number + matplotlib 2 #8483

merged 1 commit into from
Mar 2, 2017

Conversation

mathurinm
Copy link
Contributor

Reference Issue

Fixes #8482

What does this implement/fix? Explain your changes.

Any other comments?

@codecov
Copy link
8000
codecov bot commented Mar 1, 2017 •
edited
Loading

Codecov Report

Merging #8483 into master will decrease coverage by -1.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8483      +/-   ##
==========================================
- Coverage   95.47%   94.39%   -1.09%     
==========================================
  Files         342      342              
  Lines       60907    60906       -1     
==========================================
- Hits        58154    57491     -663     
- Misses       2753     3415     +662
Impacted Files Coverage Δ
sklearn/utils/_scipy_sparse_lsqr_backport.py 4.02% <0%> (-73.87%) ❌
sklearn/utils/fixes.py 31.51% <0%> (-52.95%) ❌
sklearn/utils/stats.py 59.09% <0%> (-36.37%) ❌
sklearn/utils/arpack.py 11.52% <0%> (-31.53%) ❌
sklearn/utils/sparsetools/tests/test_traversal.py 84.61% <0%> (-15.39%) ❌
sklearn/utils/tests/test_extmath.py 88.14% <0%> (-11.33%) ❌
sklearn/utils/extmath.py 87.09% <0%> (-9.68%) ❌
sklearn/_build_utils/init.py 55.1% <0%> (-6.13%) ❌
sklearn/datasets/mldata.py 93.67% <0%> (-2.54%) ❌
sklearn/neighbors/tests/test_dist_metrics.py 95.31% <0%> (-2.35%) ❌
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab5c67...7ce4470. Read the comment docs.

@raghavrv
Copy link
Member
raghavrv commented Mar 2, 2017

The example and the doc plot look good to me. +1... Awaiting review by @tguillemot for merge :)

@raghavrv raghavrv changed the title [MRG] Correct figure number + matplotlib 2 [MRG + 1] Correct figure number + matplotlib 2 Mar 2, 2017
@tguillemot
Copy link
Contributor

Much better indeed.
Thanks @mathurinm.

@agramfort
Copy link
Member

+1 for merge

@agramfort agramfort changed the title [MRG + 1] Correct figure number + matplotlib 2 [MRG + 2] Correct figure number + matplotlib 2 Mar 2, 2017
@lesteve
Copy link
Member
lesteve commented Mar 2, 2017

Not sure why the CircleCI status has not been updated since the CircleCI build has finished 22 hours ago. Anyway merging this one, thanks a lot!

@lesteve lesteve merged commit b379060 into scikit-learn:master Mar 2, 2017
@tguillemot
Copy link
Contributor

Youpi @mathurinm !!!

@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
@mathurinm @herilalaina
Correct figure number + matplotlib 2 (scikit-learn#8483)
790f16a
@lesteve lesteve mentioned this pull request Mar 29, 2017
Closed
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
@mathurinm
Correct figure number + matplotlib 2 (scikit-learn#8483)
eac660d
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@mathurinm @Sundrique
Correct figure number + matplotlib 2 (scikit-learn#8483)
4d98c40
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@mathurinm @NelleV
Correct figure number + matplotlib 2 (scikit-learn#8483)
103cc60
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@mathurinm @paulha
Correct figure number + matplotlib 2 (scikit-learn#8483)
c5df9da
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@mathurinm @maskani-moh
Correct figure number + matplotlib 2 (scikit-learn#8483)
99b09ed
@mathurinm mathurinm deleted the Fix_MOG_doc branch April 23, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tguillemot tguillemot tguillemot approved these changes

Assignees
No one assigned
Labels
Documentation Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Duplicated image in Mixture
5 participants
@mathurinm @raghavrv @tguillemot @agramfort @lesteve
0