[MRG+1] FIX/DOC Improve documentation regarding non-determinitic tree behaviour #8452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good. We should also update the website soon as that is the most visible documentation. You edited RandomForestClassifier and RandomForestRegressor as well, yes? |
Codecov Report
@@ Coverage Diff @@
## master #8452 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 342 342
Lines 60907 60907
=======================================
Hits 58154 58154
Misses 2753 2753
Continue to review full report at Codecov.
|
|
+1 for MRG |
|
@jmschrei Yes I did the change for the random forest, ijust forgot to add it in the first post |
jnothman
reviewed
Feb 26, 2017
sklearn/ensemble/forest.py
Outdated
| ----- | ||
| The features are always randomly permuted at each split. Therefore, | ||
| the best found split may vary, even with the same training data, | ||
| ``max_feature=n_features`` and ``bootstrap=False``, if the improvement |
|
Thx @glemaitre :) |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
lemonlaug
pushed a commit
to lemonlaug/scikit-learn
that referenced
this pull request
Jan 6, 2021
<
7556
input type="hidden" name="id" value="MDY6Q29tbWl0ODA2NzcyMzA6MTE4ZjRhYjZiMjI1MzQ3NjQ1MWJhNTNmODVmM2I0MTFiYTk2ODdiYw==" autocomplete="off" data-targets="batch-deferred-content.inputs" />
… behaviour (scikit-learn#8452) * FIX/DOC Improve documentation regarding non-determinitic tree behaviour * FIX correct max_features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8443
What does this implement/fix? Explain your changes.
Add details regarding the non-deterministic behaviour of decision tree.
Any other comments?
Edited:
DecisionTreeClassifierDecisionTreeRegressorGradientBoostingClassifierGradientBoostingRegressorRandomForestRegressorRandomForestClassifier