Update to Sphinx-Gallery v0.1.11 #8222
Conversation
|
Travis is failing because sphinx extensions are tested. Last version of the gallery imports from sphinx but sphinx is not installed for testing in travis. Shall sphinx be installed or shall this test be ignored? |
|
AFAIK doc/sphintext are third party extensions, I don't think we should test them. Maybe historically we had more custom code in doc/sphinxext, I am not sure. |
|
I think the issue is more that historically we didn't have docs CI. So IMO
we can remove test-sphinxext, or add it to the Circle build.
…On 24 January 2017 at 19:56, Loïc Estève ***@***.***> wrote:
AFAIK doc/sphintext are third party extensions, I don't think we should
test them.
Maybe historically we had more custom code in doc/sphinxext, I am not sure.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz67LK4A9zxn60ExTiTWEKkigCH6HZks5rVbzJgaJpZM4Lqft3>
.
|
|
#8228 is merged, if you update your PR with master, Travis should be green. |
|
Rebased, travis is green |
|
I figured it out about the download boxes being stacked. I comes from the responsive CSS layout and a mismatch in the width of the |
|
I just pushed with |
|
@Titan-C I lost track of this one sorry. Is there anything else that needs to be done on the sphinx-gallery side? |
|
I'm bringing this back to life. Especially after the new Sphinx 1.6 release breaks the builds. There are some improvements from this version jump to the gallery 0.1.11. |
|
Thanks for reviving this one. Not sure whether the CircleCI failure was a glitch, I kicked off a rebuild. |
|
Hmmm the example error seems like a genuine problem with the ichart.yahoo.com website ... From a quick googling the service seems to have been discontinued by Yahoo. For example see this link. I guess we will need a work-around in the medium-term. @Titan-C for this PR you could add plot_stock_market.py to the "expected to fail" examples. |
The service this example relies on seems discontinued, thus we skip it as an error. Once this is fixed, Sphinx-Gallery will raise the errors that the script is not failing anymore.
doc/conf.py
Outdated
| 'reference_url': { | ||
| 'sklearn': None, | ||
| 'matplotlib' 8000 : 'http://matplotlib.org', | ||
| 'numpy': 'http://docs.scipy.org/doc/numpy-1.6.0', | ||
| 'scipy': 'http://docs.scipy.org/doc/scipy-0.11.0/reference', | ||
| 'nibabel': 'http://nipy.org/nibabel'} | ||
| 'nibabel': 'http://nipy.org/nibabel'}, |
There was a problem hiding this comment.
Not sure how nibabel got in there (probably from nilearn at one point) but we should remove it since nibabel is not used in scikit-learn examples.
|
Also related to Sphinx 1.6: #8828 |
|
The generated gallery is available here. Can someone have a quick look to make sure there is nothing obviously wrong in the gallery and in the examples HTML? Maybe @jnothman @glemaitre I think this PR should be merged because:
|
|
I'm taking it a look at it. |
|
@lesteve I could not spot anything wrong related to the update apart of what you mentioned. However, I could spot a lot of examples with: ####################
# some commentsIt is usually used to split the code of the example. However, this is also the way the sphinx-gallery convert the example to notebook style. Therefore, some examples look a little bit messy. I would take some times to review the example and raise an issue. |
|
I fixed the conflicts I introduced by merging #8921. |
|
Let's merge this one! |
|
Thanks @Titan-C! |
As I first wrote earlier in #8222 (comment). I don't know why download buttons started to appear stacked, but in this PR I included a fix to give them a nicer placement, but on big screens they look to be tilted to the right. Unfortunately to fix that you really need to mess with scikit-learn website layout a lot more. |
|
OK thanks, I think this is fine for now. |
|
We have been having Circle CI failures on master: |
|
The private function in sphinx has been renamed if I am not wrong. I saw
that somewhere
…On 14 June 2017 at 14:10, Joel Nothman ***@***.***> wrote:
We have been having Circle CI failures on master:
Exception occurred:
File "/home/ubuntu/scikit-learn/doc/sphinxext/sphinx_gallery/gen_gallery.py", line 244, in setup
if 'sphinx.ext.autodoc' in app._extensions:
AttributeError: 'Sphinx' object has no attribute '_extensions'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHG9PymPuvgtiyomRTMhRjb9fZtmOhG2ks5sD82ogaJpZM4Lqft3>
.
--
Guillaume Lemaitre
INRIA Saclay - Parietal team
Center for Data Science Paris-Saclay
https://glemaitre.github.io/
|
|
It is very strange that CI fails with that error. A fix to that is
pushed in
sphinx-gallery/sphinx-gallery@e05e7d9,
and is included in this PR in this change https://github.com/scikit-learn/scikit-learn/pull/8222/files#diff-cc293bc3f7189fb04db7447b6ffbc49fL244
Might it be that other merges to master have overwritten this change?
|
|
Hmmm I don't see any recent failures in https://circleci.com/gh/scikit-learn/scikit-learn. |
|
Yes, I'm not sure why I've received emails.
…On 14 June 2017 at 23:50, Loïc Estève ***@***.***> wrote:
Hmmm I don't see any recent failures in https://circleci.com/gh/
scikit-learn/scikit-learn.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz610NTS9vTk3nsB-3scIJ3tcTlq9Xks5sD-UVgaJpZM4Lqft3>
.
|
# Conflicts: # doc/sphinxext/sphinx_gallery/__init__.py # doc/sphinxext/sphinx_gallery/_static/gallery.css # doc/sphinxext/sphinx_gallery/docs_resolv.py # doc/sphinxext/sphinx_gallery/downloads.py # doc/sphinxext/sphinx_gallery/gen_gallery.py # doc/sphinxext/sphinx_gallery/gen_rst.py # doc/sphinxext/sphinx_gallery/notebook.py # doc/sphinxext/sphinx_gallery/py_source_parser.py # doc/themes/scikit-learn/static/nature.css_t
This update includes the style change of using
titleto describe code links. This change was left pending in #7986 (comment)It also make the gallery building robust on SyntaxErrors in the examples. Plus other enhancements not directly concerning Scikit-learn.