[MRG] DOC: Upgrade to jQuery v3.1.1 #8145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not seen any problems so far. Anyone else? |
jnothman
approved these changes
Jan 8, 2017
|
Just curious, any idea why the google search box is not visible in CircleCI builds? |
|
It does look like the problem mentioned in #2254 has been fixed indeed, or rather is no longer here. |
Apparently because the CircleCI artifacts are served over HTTPS while the Google search JS is loaded over HTTP: |
|
OK thanks. The original problem does not exist and I was not able to find any issue while browsing the website on CircleCI, so merging this one. |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2254.
While working on some other website build stuff I experimented with the latest version of jQuery and the jQuery Migrate plugin. Locally the toc looks fine without deprecation messages from the plugin in the console, attempting a build to see if things check out.
Check: open/collapse behavior of the table of contents at https://7994-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/user_guide.html
Compare with: http://scikit-learn.org/dev/user_guide.html