8000 Added check_X_y to lasso_stability_path() by zorroblue · Pull Request #7534 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Added check_X_y to lasso_stability_path() #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2017
Merged

Added check_X_y to lasso_stability_path() #7534

merged 1 commit into from
Mar 3, 2017

Conversation

zorroblue
Copy link
Contributor

Reference Issue

What does this implement/fix? Explain your changes.

This fixes issue #7405 . I have added a check_X_y() to validate X and y.

Any other comments?

Sparse matrices can be accepted in finding the lasso stability path.

@amueller
Copy link
Member
amueller commented Sep 30, 2016 •
edited
Loading

Can you add a test please? Maybe with the NotAnArray class? Though just passing a list is probably enough to catch the error.

@zorroblue
Copy link
Contributor Author
zorroblue commented Oct 1, 2016 •
edited
Loading

Yes @amueller
Really sorry for the delay, I will look into the guidelines for the test.
Basically a test that fails for the current code and passes for my commit is to be done right?

@maniteja123
Copy link
Contributor
maniteja123 commented Oct 2, 2016 •
edited
Loading

Hi, you are right. The test should check if the change has the intended effect. It is called a non regression test. HTH

@agramfort agramfort merged commit 8c7ab17 into scikit-learn:master Mar 3, 2017
@agramfort
Copy link
Member

it's safe enough I guess

@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
@zorroblue @herilalaina
Added check_X_y to lasso_stability_path() (scikit-learn#7534)
c75be08
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
@zorroblue
Added check_X_y to lasso_stability_path() (scikit-learn#7534)
353ceb9
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@zorroblue @Sundrique
Added check_X_y to lasso_stability_path() (scikit-learn#7534)
d656977
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@zorroblue @NelleV
Added check_X_y to lasso_stability_path() (scikit-learn#7534)
77ce0ec
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@zorroblue @paulha
Added check_X_y to lasso_stability_path() (scikit-learn#7534)
019bb24
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@zorroblue @maskani-moh
Added check_X_y to lasso_stability_path() (scikit-learn#7534)
fd585bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zorroblue @amueller @maniteja123 @agramfort
0