fix of #6580: Exporting a single node DecisionTreeClassifier to dot graph raises error when filled is True #6582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ero error. Add corresponding unit test.
| (colors['bounds'][1] - | ||
| colors['bounds'][0])), 0)) | ||
| if colors['bounds'][0] == colors['bounds'][1]: | ||
| alpha = 255 |
There was a problem hiding this comment.
nitpick: Or would it be fun to multiply this by the impurity? (Just wondering out aloud)
|
Thanks for the pull request :) LGTM pending nitpick! @tguillemot @glouppe second review? |
| export_graphviz(dtc, out_file=out, filled=True) | ||
|
|
||
| contents1 = out.getvalue() | ||
| contents2 = 'digraph Tree {\n' \ |
There was a problem hiding this comment.
Could you avoid \ and use brackets instead?
contents2 = ('digraph Tree {\n'
'continuation of the line'
...)
There was a problem hiding this comment.
nitpick: contents2 --> expected?
|
closing as #6376 is merged |
|
Apologies @andrewshir for raising a duplicate issue! Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6580 fix: add check for equal color bounds to prevent division by zero error. Add corresponding unit test.