[MRG + 1] Fix 5663: string compari 10000 son on arrays in new Gaussian process #5701
Conversation
| fixed = (bounds == "fixed") | ||
| fixed = False | ||
| if isinstance(bounds, six.string_types) and bounds == "fixed": | ||
| fixed = True |
There was a problem hiding this comment.
or
fixed = isinstance(bounds, six.string_types) and bounds == "fixed"
There was a problem hiding this comment.
You're right I like one line more, so I'll change it your way, thanks.
|
It would be really good to have a test, for instance derived from the original issue. |
|
@GaelVaroquaux |
|
@amueller Do I understand this correctly that I should not write tests for this? And instead warnings should be treated as errors? |
|
I'm just curious, should I add something before merge or is it ok like this? |
|
Yes, this is good to merge. This raises warnings, not errors, at the moment, so we can't really test. Well we could test that no warning is raised but that is a bit overkill, I think. |
[MRG + 1] Fix 5663: string comparison on arrays in new Gaussian process
|
Thanks for the fix @ziky90! |
This PR fixes the issue described in described in issue #5663