-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG + 1] Fix MLP batch_size test warning for default value #5699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For #5670 |
Gentle ping @amueller |
LGTM. Sorry for the delay. |
@bhargav rebase and push again; appveyor is not failing anymore |
5ff3d02
to
0fc7087
Compare
Rebased. |
So the value Otherwise, LGTM |
I think the 200 should be back in. It should have the same behaviour as before. |
78442c4
to
6731980
Compare
Update PR as per comments. Sorry for the delay. |
Could you please squash the commits? otherwise I think this is good to go. Any other review? @TomDLT ? |
Fix default value for batch_size for 'auto' to be min(200, n_samples)
6731980
to
3d001f3
Compare
LGTM |
[MRG + 1] Fix MLP batch_size test warning for default value
thanks :) |
Initializing batch_size to 'auto' and setting it to n_samples value
for the default case.