-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[WIP] Make LabelEncoder more friendly to new labels #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
4d79789
Adding new_labels argument to LabelEncoder
mjbommar 2bc5686
Adding tests for new_labels argument.
mjbommar 8c1fafe
Changing classes_ update strategy
mjbommar 1ffb24a
Adding nan behavior, renaming to
mjbommar 99f65a9
Updating tests to include nan case and update name
mjbommar af8c6a9
Fixing docstring for test-doc pass
mjbommar 8ffc839
Fixing docstring for test-doc pass (for real)
mjbommar e6fbc47
Updating doctests
mjbommar 46118d9
Updating constructor documentation
mjbommar 8d21ec1
Adding specific "label" option to new_labels
mjbommar 343c726
Adding test for "label" option to ``new_labels``
mjbommar be97c14
Updating docstring for ``new_labels="label"``
mjbommar cdd7147
pep8
mjbommar 170d00c
Autodoc fix
mjbommar 2d87e88
Fixing rst docs
mjbommar bb8d9a6
Changing dtypes for new_labels
mjbommar ab788f7
Adding example for new_labels argument
mjbommar a597fc3
Adding new_labels handling to fit/fit_transform
mjbommar 291d752
Improving difficulty of test cases with non-increasing unseen labels
mjbommar fe0141d
Moving ValueError check to fit
mjbommar e1b7ed5
Improving difficult for new_labels='update' test to include multiple …
mjbommar 9fd7736
Fixing negative indexing, renamed z->out, failing approach for new_la…
mjbommar e3c14bb
PEP8
mjbommar fe79736
Removing nan option and corresponding test
mjbommar b83b37f
Handling repeated transform calls with new_class_mapping_, refactorin…
mjbommar 0b8e63c
Update outlier_detection.rst
pvnguyen 62f1f57
Added directory checking for documentation builds, and corrected for …
kastnerkyle 8cd5d85
Merge pull request #3477 from kastnerkyle/docbuild_fix
kastnerkyle 965b109
Merge pull request #3479 from MechCoder/improve_logcv_docs
larsmans d814353
MAINT More robust windows installation script
ogrisel 0af2d8f
MAINT move skip for unstable 32bit to _check_transformer
ogrisel f3afd4e
FIX unstable test on 32 bit windows
ogrisel 376ac51
Merge pull request #3465 from pvnguyen/patch-1
agramfort 4b6978e
Adding new_labels argument to LabelEncoder
mjbommar d990207
Adding tests for new_labels argument.
mjbommar a69840b
Changing classes_ update strategy
mjbommar fce9fb5
Adding nan behavior, renaming to
mjbommar 76921e5
Updating tests to include nan case and update name
mjbommar 0e39a2a
Fixing docstring for test-doc pass
mjbommar 1da2880
Fixing docstring for test-doc pass (for real)
mjbommar 926b166
Updating doctests
mjbommar 5ef9b85
Updating constructor documentation
mjbommar 4dfb4cb
Adding specific "label" option to new_labels
mjbommar 392e54b
Adding test for "label" option to ``new_labels``
mjbommar e053635
Updating docstring for ``new_labels="label"``
mjbommar 122a98f
pep8
mjbommar de18372
Autodoc fix
mjbommar d735ca2
Fixing rst docs
mjbommar d276565
Changing dtypes for new_labels
mjbommar a01f8b0
8000
Adding example for new_labels argument
mjbommar 495347c
Adding new_labels handling to fit/fit_transform
mjbommar dee4ae0
Improving difficulty of test cases with non-increasing unseen labels
mjbommar c297017
Moving ValueError check to fit
mjbommar f29800b
Improving difficult for new_labels='update' test to include multiple …
mjbommar 74b7589
Fixing negative indexing, renamed z->out, failing approach for new_la…
mjbommar 3e1be5d
PEP8
mjbommar abf01cc
Removing nan option and corresponding test
mjbommar f26a902
Handling repeated transform calls with new_class_mapping_, refactorin…
mjbommar 0725d4c
Rebase
mjbommar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing on
fit
is probably kinder to the user.