DOC: Add missing link to plot_logistic.py in Logistic Regression documentation #30942
Conversation
|
Hello @shbradki, thank you for your PR! The links seem well placed to me, but you have to take care of the linting issues (the lines are too long). Best is to install |
There was a problem hiding this comment.
Thank you @shbradki, that's a valuable addition to the docs.
I only have a few nits.
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Thank you, I thought I had edited the rst file as well but evidently not. Thanks for the correction! |
|
Happy this PR moved so fast. @adrinjalali, can we merge it? |
|
@shbradki thank for the contribution. Looking at the example, I find the example a bit odd. It's comparing a regression model (linear regression) with a classification model (logistic regression). On top of that, we already have other, much better logistic regression examples. So I think we can remove the example altogether, and redirect to one of the existing examples. You can check an example of how to do so here: #30906 |
|
Hi @shbradki, would you want to work on what @adrinjalali had suggested? |
|
Hi @adrinjalali @StefanieSenger So sorry about the delayed response, I'm just seeing this. I appreciate the feedback and would be happy to work on that. I'll remove the reference to plot_logistic.py and update the reference to point to a more relevant logistic regression example. Will follow up shortly with a revised commit. |
|
Awesome, @shbradki! :) |
|
hey @StefanieSenger can i work on this |
|
Hi, @Gouravbirwaz. @shbradki is already working on it. Feel free, for instance, to check out #30621 (or other beginner-friendly issues) to find a new task for yourself. |
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
Adds a missing reference to plot_logistic.py in the Logistic Regression section of the User Guide (linear_model.rst).
Updates the LogisticRegression docstring (_logistic.py) to include a reference to the example.
Any other comments?