From b7dc486e0498240aaa39f335132c701d38507e4c Mon Sep 17 00:00:00 2001 From: Olivier Grisel Date: Thu, 27 Jun 2024 20:47:03 +0200 Subject: [PATCH 1/2] Pin the ruff version on CI linters --- .circleci/config.yml | 2 +- .github/workflows/lint.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 1f9a1a02e0f62..7a98f88b813ad 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -11,7 +11,7 @@ jobs: command: | source build_tools/shared.sh # Include pytest compatibility with mypy - pip install pytest ruff $(get_dep mypy min) $(get_dep black min) cython-lint + pip install pytest $(get_dep ruff min) $(get_dep mypy min) $(get_dep black min) cython-lint - run: name: linting command: ./build_tools/linting.sh diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index a06f636d363a5..e2de3bbde583b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -33,7 +33,7 @@ jobs: run: | source build_tools/shared.sh # Include pytest compatibility with mypy - pip install pytest ruff $(get_dep mypy min) $(get_dep black min) cython-lint + pip install pytest $(get_dep ruff min) $(get_dep mypy min) $(get_dep black min) cython-lint # we save the versions of the linters to be used in the error message later. python -c "from importlib.metadata import version; print(f\"ruff={version('ruff')}\")" >> /tmp/versions.txt python -c "from importlib.metadata import version; print(f\"mypy={version('mypy')}\")" >> /tmp/versions.txt From 32caffd5a81acdc7197036c30de5261edafdce6d Mon Sep 17 00:00:00 2001 From: Olivier Grisel Date: Thu, 27 Jun 2024 21:00:29 +0200 Subject: [PATCH 2/2] Pin the ruff version on azure pipelines --- azure-pipelines.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index ff9d7f7813027..e8e2956107797 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -35,7 +35,7 @@ jobs: - bash: | source build_tools/shared.sh # Include pytest compatibility with mypy - pip install pytest ruff $(get_dep mypy min) $(get_dep black min) cython-lint + pip install pytest $(get_dep ruff min) $(get_dep mypy min) $(get_dep black min) cython-lint displayName: Install linters - bash: | ./build_tools/linting.sh